Various DDC fixes for windows

pkg/dev_compiler/test/worker/worker_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 
 import 'package:bazel_worker/bazel_worker.dart';
 // TODO(jakemac): Remove once this is a part of the testing library.
 import 'package:bazel_worker/src/async_message_grouper.dart';
 import 'package:bazel_worker/testing.dart';
+import 'package:path/path.dart' show join, joinAll, toUri;
 import 'package:test/test.dart';
 
+File file(String path) => new File(joinAll(path.split('/'))).absolute;
+
 main() {
+  var dartdevc = join('bin', 'dartdevc.dart');
   group('Hello World', () {
-    final argsFile = new File('test/worker/hello_world.args').absolute;
-    final inputDartFile = new File('test/worker/hello_world.dart').absolute;
-    final outputJsFile = new File('test/worker/out/hello_world.js').absolute;
-    final dartSdkSummary = new File('lib/sdk/ddc_sdk.sum').absolute;
-    final executableArgs = ['bin/dartdevc.dart'];
+    final argsFile = file('test/worker/hello_world.args');
+    final inputDartFile = file('test/worker/hello_world.dart');
+    final outputJsFile = file('test/worker/out/hello_world.js');
+    final dartSdkSummary = file('lib/sdk/ddc_sdk.sum');
+    final executableArgs = [dartdevc];
     final compilerArgs = [
       '--no-source-map',
       '--no-summarize',
       '--dart-sdk-summary',
       dartSdkSummary.path,
       '-o',
       outputJsFile.path,
       inputDartFile.path,
     ];
 
@@ skipping 86 matching lines @@
       stderr.addStream(process.stderr);
       var futureProcessOutput = process.stdout.map(UTF8.decode).toList();
 
       expect(await process.exitCode, EXIT_CODE_OK);
       expect((await futureProcessOutput).join(), isEmpty);
       expect(outputJsFile.existsSync(), isTrue);
     });
   });
 
   group('Hello World with Summaries', () {
-    final greetingDart = new File('test/worker/greeting.dart').absolute;
-    final helloDart = new File('test/worker/hello.dart').absolute;
+    final greetingDart = file('test/worker/greeting.dart');
+    final helloDart = file('test/worker/hello.dart');
 
-    final greetingJS = new File('test/worker/greeting.js').absolute;
-    final greetingSummary = new File('test/worker/greeting.api.ds').absolute;
-    final helloJS = new File('test/worker/hello_world.js').absolute;
+    final greetingJS = file('test/worker/greeting.js');
+    final greetingSummary = file('test/worker/greeting.api.ds');
+    final helloJS = file('test/worker/hello_world.js');
 
-    final greeting2JS = new File('test/worker/greeting2.js').absolute;
-    final greeting2Summary = new File('test/worker/greeting2.api.ds').absolute;
+    final greeting2JS = file('test/worker/greeting2.js');
+    final greeting2Summary = file('test/worker/greeting2.api.ds');
 
     setUp(() {
       greetingDart.writeAsStringSync('String greeting = "hello";');
       helloDart.writeAsStringSync('import "greeting.dart";'
           'main() => print(greeting);');
     });
 
     tearDown(() {
       if (greetingDart.existsSync()) greetingDart.deleteSync();
       if (helloDart.existsSync()) helloDart.deleteSync();
       if (greetingJS.existsSync()) greetingJS.deleteSync();
       if (greetingSummary.existsSync()) greetingSummary.deleteSync();
       if (greeting2JS.existsSync()) greeting2JS.deleteSync();
       if (greeting2Summary.existsSync()) greeting2Summary.deleteSync();
       if (helloJS.existsSync()) helloJS.deleteSync();
     });
 
     test('can compile in basic mode', () {
-      final dartSdkSummary = new File('lib/sdk/ddc_sdk.sum').absolute;
+      final dartSdkSummary = file('lib/sdk/ddc_sdk.sum');
       var result = Process.runSync(Platform.executable, [
-        'bin/dartdevc.dart',
+        dartdevc,
         '--summary-extension=api.ds',
         '--no-source-map',
         '--dart-sdk-summary',
         dartSdkSummary.path,
         '-o',
         greetingJS.path,
         greetingDart.path,
       ]);
       expect(result.exitCode, EXIT_CODE_OK);
       expect(result.stdout, isEmpty);
       expect(result.stderr, isEmpty);
       expect(greetingJS.existsSync(), isTrue);
       expect(greetingSummary.existsSync(), isTrue);
 
       result = Process.runSync(Platform.executable, [
-        'bin/dartdevc.dart',
+        dartdevc,
         '--no-source-map',
         '--no-summarize',
         '--dart-sdk-summary',
         dartSdkSummary.path,
         '--summary-extension=api.ds',
         '-s',
         greetingSummary.path,
         '-o',
         helloJS.path,
         helloDart.path,
       ]);
       expect(result.exitCode, EXIT_CODE_OK);
       expect(result.stdout, isEmpty);
       expect(result.stderr, isEmpty);
       expect(helloJS.existsSync(), isTrue);
     });
 
     test('reports error on overlapping summaries', () {
-      final dartSdkSummary = new File('lib/sdk/ddc_sdk.sum').absolute;
+      final dartSdkSummary = file('lib/sdk/ddc_sdk.sum');
       var result = Process.runSync(Platform.executable, [
-        'bin/dartdevc.dart',
+        dartdevc,
         '--summary-extension=api.ds',
         '--no-source-map',
         '--dart-sdk-summary',
         dartSdkSummary.path,
         '-o',
         greetingJS.path,
         greetingDart.path,
       ]);
       expect(result.exitCode, EXIT_CODE_OK);
       expect(result.stdout, isEmpty);
       expect(result.stderr, isEmpty);
       expect(greetingJS.existsSync(), isTrue);
       expect(greetingSummary.existsSync(), isTrue);
 
       result = Process.runSync(Platform.executable, [
-        'bin/dartdevc.dart',
+        dartdevc,
         '--summary-extension=api.ds',
         '--no-source-map',
         '--dart-sdk-summary',
         dartSdkSummary.path,
         '-o',
         greeting2JS.path,
         greetingDart.path,
       ]);
       expect(result.exitCode, EXIT_CODE_OK);
       expect(result.stdout, isEmpty);
       expect(result.stderr, isEmpty);
       expect(greeting2JS.existsSync(), isTrue);
       expect(greeting2Summary.existsSync(), isTrue);
 
       result = Process.runSync(Platform.executable, [
-        'bin/dartdevc.dart',
+        dartdevc,
         '--no-source-map',
         '--no-summarize',
         '--dart-sdk-summary',
         dartSdkSummary.path,
         '--summary-extension=api.ds',
         '-s',
         greetingSummary.path,
         '-s',
         greeting2Summary.path,
         '-o',
         helloJS.path,
         helloDart.path,
       ]);
       expect(result.exitCode, 65);
       expect(result.stdout, contains("conflict"));
-      expect(result.stdout, contains(greetingDart.path));
+      expect(result.stdout, contains('${toUri(greetingDart.path)}'));
       expect(helloJS.existsSync(), isFalse);
     });
   });
 
   group('Error handling', () {
-    final dartSdkSummary = new File('lib/sdk/ddc_sdk.sum').absolute;
-    final badFileDart = new File('test/worker/bad.dart').absolute;
-    final badFileJs = new File('test/worker/bad.js').absolute;
+    final dartSdkSummary = file('lib/sdk/ddc_sdk.sum');
+    final badFileDart = file('test/worker/bad.dart');
+    final badFileJs = file('test/worker/bad.js');
 
     tearDown(() {
       if (badFileDart.existsSync()) badFileDart.deleteSync();
       if (badFileJs.existsSync()) badFileJs.deleteSync();
     });
 
     test('incorrect usage', () {
       var result = Process.runSync(Platform.executable, [
-        'bin/dartdevc.dart',
+        dartdevc,
         '--dart-sdk-summary',
         dartSdkSummary.path,
         'oops',
       ]);
       expect(result.exitCode, 64);
       expect(
           result.stdout, contains('Please include the output file location.'));
       expect(result.stdout, isNot(contains('#0')));
     });
 
     test('compile errors', () {
       badFileDart.writeAsStringSync('main() => "hello world"');
       var result = Process.runSync(Platform.executable, [
-        'bin/dartdevc.dart',
+        dartdevc,
         '--no-source-map',
         '--dart-sdk-summary',
         dartSdkSummary.path,
         '-o',
         badFileJs.path,
         badFileDart.path,
       ]);
       expect(result.exitCode, 1);
       expect(result.stdout, contains("[error] Expected to find ';'"));
     });
   });
 
   group('Parts', () {
-    final dartSdkSummary = new File('lib/sdk/ddc_sdk.sum').absolute;
-    final partFile = new File('test/worker/greeting.dart').absolute;
-    final libraryFile = new File('test/worker/hello.dart').absolute;
+    final dartSdkSummary = file('lib/sdk/ddc_sdk.sum');
+    final partFile = file('test/worker/greeting.dart');
+    final libraryFile = file('test/worker/hello.dart');
 
-    final outJS = new File('test/worker/output.js').absolute;
+    final outJS = file('test/worker/output.js');
 
     setUp(() {
       partFile.writeAsStringSync('part of hello;\n'
           'String greeting = "hello";');
       libraryFile.writeAsStringSync('library hello;\n'
           'part "greeting.dart";\n'
           'main() => print(greeting);\n');
     });
 
     tearDown(() {
       if (partFile.existsSync()) partFile.deleteSync();
       if (libraryFile.existsSync()) libraryFile.deleteSync();
       if (outJS.existsSync()) outJS.deleteSync();
     });
 
     test('works if part and library supplied', () {
       var result = Process.runSync(Platform.executable, [
-        'bin/dartdevc.dart',
+        dartdevc,
         '--no-summarize',
         '--no-source-map',
         '--dart-sdk-summary',
         dartSdkSummary.path,
         '-o',
         outJS.path,
         partFile.path,
         libraryFile.path,
       ]);
       expect(result.stdout, isEmpty);
       expect(result.stderr, isEmpty);
       expect(result.exitCode, 0);
       expect(outJS.existsSync(), isTrue);
     });
 
     test('works if part is not supplied', () {
       var result = Process.runSync(Platform.executable, [
-        'bin/dartdevc.dart',
+        dartdevc,
         '--no-summarize',
         '--no-source-map',
         '--dart-sdk-summary',
         dartSdkSummary.path,
         '-o',
         outJS.path,
         libraryFile.path,
       ]);
       expect(result.stdout, isEmpty);
       expect(result.stderr, isEmpty);
       expect(result.exitCode, 0);
       expect(outJS.existsSync(), isTrue);
     });
 
     test('part without library is silently ignored', () {
       var result = Process.runSync(Platform.executable, [
-        'bin/dartdevc.dart',
+        dartdevc,
         '--no-summarize',
         '--no-source-map',
         '--dart-sdk-summary',
         dartSdkSummary.path,
         '-o',
         outJS.path,
         partFile.path,
       ]);
       expect(result.stdout, isEmpty);
       expect(result.stderr, isEmpty);
       expect(result.exitCode, 0);
       expect(outJS.existsSync(), isTrue);
     });
   });
 }
 
 Future<WorkResponse> _readResponse(MessageGrouper messageGrouper) async {
   var buffer = (await messageGrouper.next) as List<int>;
   try {
     return new WorkResponse.fromBuffer(buffer);
   } catch (_) {
     var bufferAsString =
         buffer == null ? '' : 'String: ${UTF8.decode(buffer)}\n';
     throw 'Failed to parse response:\nbytes: $buffer\n$bufferAsString';
   }
 }