Various DDC fixes for windows

pkg/dev_compiler/test/codegen_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Tests code generation.
 ///
 /// Runs Dart Dev Compiler on all input in the `codegen` directory and checks
 /// that the output is what we expected.
 library dev_compiler.test.codegen_test;
 
@@ skipping 147 matching lines @@
       }
       JSModuleFile module = null;
       var exception, stackTrace;
       try {
         module = compiler.compile(unit, options);
       } catch (e, st) {
         exception = e;
         stackTrace = st;
       }
 
-      bool expectedCompileTimeError =
-          contents.contains(': compile-time error\n');
+      bool expectedCompileTimeError = contents.contains(': compile-time error');
       bool notStrong = notYetStrongTests.contains(name);
       bool crashing = _crashingTests.contains(name);
+      bool inconsistent = _inconsistentTests.contains(name);
 
       if (module == null) {
         expect(crashing, isTrue,
             reason: "test $name crashes during compilation.\n"
                 "$exception\n$stackTrace");
+      } else if (inconsistent) {
+        // An inconsistent test will only compile on some platforms (see
+        // comment below).  It should not crash however.
+        expect(crashing, isFalse, reason: "test $name no longer crashes.");
       } else if (module.isValid) {
         _writeModule(
             path.join(codegenOutputDir, name),
             isTopLevelTest ? path.join(codegenExpectDir, name) : null,
             moduleFormat,
             module);
 
         expect(crashing, isFalse, reason: "test $name no longer crashes.");
         // TODO(vsm): We don't seem to trip on non-strong errors?
         // expect(expectedCompileTimeError, isFalse,
         //    reason: "test $name expected compilation errors, but compiled.");
         expect(notStrong, isFalse,
             reason: "test $name expected strong mode errors, but compiled.");
       } else {
         expect(crashing, isFalse, reason: "test $name no longer crashes.");
-        var reason =
-            expectedCompileTimeError ? "expected" : "untriaged strong mode";
-        expect(expectedCompileTimeError || notStrong, isTrue,
+        var reason = expectedCompileTimeError
+            ? "expected"
+            : inconsistent ? "platform consistency" : "untriaged strong mode";
+        expect(expectedCompileTimeError || inconsistent || notStrong, isTrue,
             reason: "test $name failed to compile due to $reason errors:"
                 "\n\n${module.errors.join('\n')}.");
       }
     });
   }
 
   if (filePattern.hasMatch('sunflower')) {
     test('sunflower', () {
       _buildSunflower(sharedCompiler, codegenOutputDir, codegenExpectDir);
     });
@@ skipping 59 matching lines @@
 
 List<String> _setUpTests(List<String> testDirs) {
   var testFiles = <String>[];
 
   for (var testDir in testDirs) {
     // Look for the tests in the "_strong" directories in the SDK's main
     // "tests" directory.
     var dirParts = path.split(testDir);
     var sdkTestDir =
         path.join(dirParts[0] + "_strong", path.joinAll(dirParts.skip(1)));
-    var inputPath = path.join(testDirectory, '../../../tests/', sdkTestDir);
+    var inputPath =
+        path.join(testDirectory, '..', '..', '..', 'tests', sdkTestDir);
 
     for (var file in _listFiles(inputPath, recursive: true)) {
       var relativePath = path.relative(file, from: inputPath);
       var outputPath = path.join(codegenTestDir, testDir, relativePath);
 
       _ensureDirectory(path.dirname(outputPath));
 
       // Copy it over. We do this even for multitests because import_self_test
       // is a multitest, yet imports its own unexpanded form (!).
       new File(file).copySync(outputPath);
@@ skipping 94 matching lines @@
   String uriContent = uriLiteral.stringValue;
   if (uriContent != null) {
     uriContent = uriContent.trim();
     directive.uriContent = uriContent;
   }
   return (directive as UriBasedDirectiveImpl).validate() == null
       ? uriContent
       : null;
 }
 
+/// Tests that, due to bugs, are strong-mode clean only on some platforms.
+final _inconsistentTests = new Set<String>.from([
+  // This test is clean on windows, but not linux/mac due to newline encoding.
+  // See: https://github.com/dart-lang/sdk/issues/27224
+  'language/multiline_newline_test_02_multi',
+].map((p) => p.replaceAll('/', path.separator)));
+
 final _crashingTests = new Set<String>.from([
   'language/generic_methods_generic_class_tearoff_test',
   'language/generic_methods_named_parameters_test',
   'language/generic_methods_optional_parameters_test',
   'language/generic_methods_tearoff_specialization_test',
   'language/generic_methods_unused_parameter_test',
 
   // TODO(vsm): Fix these - they import files from a different directory
   // - this triggers an invalid library root build error.
   'lib/html/custom/attribute_changed_callback_test',
   'lib/html/custom/constructor_calls_created_synchronously_test',
   'lib/html/custom/entered_left_view_test',
   'lib/html/custom/js_custom_test',
   'lib/html/custom/mirrors_test',
   'lib/html/custom/regress_194523002_test',
-]);
+].map((p) => p.replaceAll('/', path.separator)));