chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc - Issue 2833603003: Log the creation of more dialog box types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc

Issue 2833603003: Log the creation of more dialog box types. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_dialogs.h ('K') | « chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc ('k') | chrome/browser/ui/views/global_error_bubble_view.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc

diff --git a/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc b/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc

index 21746f13bd49591347c2334ac0f787607570d2b6..21f583438f4030e8d5b64f78e29f98941ef4c0e8 100644

--- a/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc

+++ b/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc

@@ -10,6 +10,7 @@

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/extensions/extension_uninstall_dialog.h"

#include "chrome/browser/ui/app_list/app_list_service.h"

+#include "chrome/browser/ui/browser_dialogs.h"

#include "chrome/browser/ui/native_window_tracker.h"

#include "chrome/browser/ui/views/harmony/chrome_layout_provider.h"

#include "chrome/grit/generated_resources.h"

@@ -188,6 +189,8 @@ ExtensionUninstallDialogDelegateView::ExtensionUninstallDialogDelegateView(

heading_->SetAllowCharacterBreak(true);

heading_->SizeToFit(kRightColumnWidth);

AddChildView(heading_);

+ chrome::RecordDialogCreation(chrome::DialogIdentifier::EXTENSION_UNINSTALL);

}

ExtensionUninstallDialogDelegateView::~ExtensionUninstallDialogDelegateView() {