Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(20)

Issue 2833603003: Log the creation of more dialog box types. (Closed)

Created:
1 year, 1 month ago by pdyson
Modified:
1 year ago
Reviewers:
msw, jwd
CC:
asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, estade+watch_chromium.org, extensions-reviews_chromium.org, mathp+autofillwatch_chromium.org, rogerm+autofillwatch_chromium.org, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, tfarina, vabr+watchlistautofill_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Log the creation of more dialog box types. Increase the number of dialog box types that have their creation logged. These are simple cases, where the logging is in the constructor. Future cls will include more complex cases. BUG=705331 Review-Url: https://codereview.chromium.org/2833603003 Cr-Commit-Position: refs/heads/master@{#467195} Committed: https://chromium.googlesource.com/chromium/src/+/106455b2f89608b7225f03fe71593332aa4eddfe

Patch Set 1 #

Total comments: 5

Patch Set 2 : remove "_BUBBLE" #

Patch Set 3 : Fix simple merge conflict. #

Messages

Total messages: 23 (13 generated)
pdyson
1 year, 1 month ago (2017-04-20 05:17:08 UTC) #3
msw
lgtm without 'bubble' in name/label. https://codereview.chromium.org/2833603003/diff/1/chrome/browser/ui/browser_dialogs.h File chrome/browser/ui/browser_dialogs.h (right): https://codereview.chromium.org/2833603003/diff/1/chrome/browser/ui/browser_dialogs.h#newcode215 chrome/browser/ui/browser_dialogs.h:215: EXTENSION_INSTALLED_BUBBLE = 23, q: ...
1 year, 1 month ago (2017-04-20 18:06:02 UTC) #4
pdyson
Mike - a question about removing "bubble". https://codereview.chromium.org/2833603003/diff/1/chrome/browser/ui/browser_dialogs.h File chrome/browser/ui/browser_dialogs.h (right): https://codereview.chromium.org/2833603003/diff/1/chrome/browser/ui/browser_dialogs.h#newcode215 chrome/browser/ui/browser_dialogs.h:215: EXTENSION_INSTALLED_BUBBLE = ...
1 year, 1 month ago (2017-04-21 00:49:53 UTC) #5
msw
https://codereview.chromium.org/2833603003/diff/1/chrome/browser/ui/browser_dialogs.h File chrome/browser/ui/browser_dialogs.h (right): https://codereview.chromium.org/2833603003/diff/1/chrome/browser/ui/browser_dialogs.h#newcode215 chrome/browser/ui/browser_dialogs.h:215: EXTENSION_INSTALLED_BUBBLE = 23, On 2017/04/21 00:49:53, pdyson wrote: > ...
1 year, 1 month ago (2017-04-21 01:58:19 UTC) #6
pdyson
On 2017/04/21 at 01:58:19, msw wrote: > https://codereview.chromium.org/2833603003/diff/1/chrome/browser/ui/browser_dialogs.h > File chrome/browser/ui/browser_dialogs.h (right): > > https://codereview.chromium.org/2833603003/diff/1/chrome/browser/ui/browser_dialogs.h#newcode215 ...
1 year, 1 month ago (2017-04-24 05:36:56 UTC) #11
pdyson
Jesse, can you take a look at this now?
1 year, 1 month ago (2017-04-24 05:37:17 UTC) #12
jwd
lgtm
1 year ago (2017-04-24 21:11:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833603003/20001
1 year ago (2017-04-25 23:24:27 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833603003/40001
1 year ago (2017-04-25 23:50:05 UTC) #20
commit-bot: I haz the power
1 year ago (2017-04-26 01:22:07 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/106455b2f89608b7225f03fe7159...

Powered by Google App Engine
This is Rietveld 408576698