Log the creation of more dialog box types.

chrome/browser/ui/browser_dialogs.h

Index: chrome/browser/ui/browser_dialogs.h
diff --git a/chrome/browser/ui/browser_dialogs.h b/chrome/browser/ui/browser_dialogs.h
index 11f69150304727ff44649c760d7501681f4097ec..69ca36d822660f315b7d0f4c6efd0dede5831c6a 100644
--- a/chrome/browser/ui/browser_dialogs.h
+++ b/chrome/browser/ui/browser_dialogs.h
@@ -208,6 +208,14 @@ enum class DialogIdentifier {
   CONFLICTING_MODULE = 16,
   CRITICAL_NOTIFICATION = 17,
   IME_WARNING = 18,
+  TOOLBAR_ACTIONS_BAR = 19,
+  GLOBAL_ERROR = 20,
+  EXTENSION_INSTALL = 21,
+  EXTENSION_UNINSTALL = 22,
+  EXTENSION_INSTALLED_BUBBLE = 23,

[msw, 2017/04/20 18:06:02]

q: why name this with 'bubble', but not others, eg. SAVE_CARD for
SaveCardBubbleViews and GLOBAL_ERROR for GlobalErrorBubbleView, etc.? I'd
probably skip adding bubble to any ENUM values, unless it's more critical to
describing the value, like CONFIRM_BUBBLE

[pdyson, 2017/04/21 00:49:53]

I was concerned that having EXTENSION_INSTALL and EXTENSION_INSTALLED would lead
to confusion, so I called out which one was "bubble". I realize that this is
inconsistent with other "bubble" dialogs, but I went with what I see as clarity
over consistency. However, I could remove "_BUBBLE" and it would still be clear
in the dashboard, although still possibly confusing in the code.

What do you think?

[msw, 2017/04/21 01:58:19]

I think *INSTALL AND *INSTALLED is fine. As you said, you can clarify the labels
in the dashboard, and the code points to the appropriate classes.

+  PAYMENT_REQUEST = 24,
+  SAVE_CARD = 25,
+  CARD_UNMASK = 26,
   MAX_VALUE
 };