tools/metrics/histograms/histograms.xml - Issue 2833603003: Log the creation of more dialog box types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2833603003: Log the creation of more dialog box types. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 833186182ddc8f53334021824f6469a81ab93d44..57faf7dfbb1c18ea88a0ca1a8f4ae98136cb68fb 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -89425,6 +89425,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

+ <int value="19" label="Toolbar Actions Bar"/>

+ <int value="20" label="Global Error"/>

+ <int value="21" label="Extension Install"/>

+ <int value="22" label="Extension Uninstall"/>

+ <int value="23" label="Extension Installed Bubble (Sideloaded)"/>

msw 2017/04/20 18:06:02 ditto nit: remove "Bubble" here

pdyson 2017/04/21 00:49:53 I've fine with removing "bubble" here as "(Sideloa

+ <int value="24" label="Payment Request"/>

+ <int value="25" label="Save Card"/>

+ <int value="26" label="Card Unmask"/>

</enum>