Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2833533003: Update Crashpad to f487da4ff2c47a129e2f8f3a7e0c769b54e4585f (Closed)

Created:
3 years, 8 months ago by Mark Mentovai
Modified:
3 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Crashpad to f487da4ff2c47a129e2f8f3a7e0c769b54e4585f ffe4c1018c1b net: Update Blink source code references e04194afd91d win: Wrap TerminateProcess() to accept cdecl patches on x86 74fddc3fed2a win: Wrap test::ChildLauncher::Start() in ASSERT_NO_FATAL_FAILURE() f487da4ff2c4 win handler: Move test targets to handler_test.gyp BUG=crashpad:179 Review-Url: https://codereview.chromium.org/2833533003 Cr-Commit-Position: refs/heads/master@{#465723} Committed: https://chromium.googlesource.com/chromium/src/+/e672411293885c984f074000d465b789c2cefb7d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+518 lines, -162 lines) Patch
M build/secondary/third_party/crashpad/crashpad/util/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/crashpad/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/client/crashpad_client_win.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M third_party/crashpad/crashpad/handler/handler.gyp View 1 chunk +0 lines, -111 lines 0 comments Download
M third_party/crashpad/crashpad/handler/handler_test.gyp View 1 chunk +134 lines, -22 lines 0 comments Download
M third_party/crashpad/crashpad/handler/win/crash_other_program.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/extra_memory_ranges_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/pe_image_annotations_reader_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/snapshot/win/process_snapshot_win_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/crashpad/crashpad/test/win/child_launcher.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/net/http_multipart_builder.cc View 2 chunks +7 lines, -12 lines 0 comments Download
M third_party/crashpad/crashpad/util/util.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/util_test.gyp View 3 chunks +9 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/win/capture_context.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/crashpad/crashpad/util/win/exception_handler_server.cc View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/crashpad/crashpad/util/win/process_info_test.cc View 1 chunk +1 line, -1 line 0 comments Download
A third_party/crashpad/crashpad/util/win/safe_terminate_process.h View 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/util/win/safe_terminate_process.asm View 1 chunk +74 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/util/win/safe_terminate_process_test.cc View 1 chunk +185 lines, -0 lines 0 comments Download
A third_party/crashpad/crashpad/util/win/safe_terminate_process_test_child.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/crashpad/crashpad/util/win/termination_codes.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Mark Mentovai
I want to get this asm out there to see if it helps.
3 years, 8 months ago (2017-04-19 18:46:34 UTC) #3
scottmg
lgtm
3 years, 8 months ago (2017-04-19 18:49:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833533003/1
3 years, 8 months ago (2017-04-19 18:53:37 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 20:08:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e672411293885c984f074000d465...

Powered by Google App Engine
This is Rietveld 408576698