third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc - Issue 2833533003: Update Crashpad to f487da4ff2c47a129e2f8f3a7e0c769b54e4585f

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc

Issue 2833533003: Update Crashpad to f487da4ff2c47a129e2f8f3a7e0c769b54e4585f (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/handler/win/crash_other_program.cc ('k') | third_party/crashpad/crashpad/snapshot/win/extra_memory_ranges_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc

diff --git a/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc b/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc

index e2776964809ef848973ece901edd2355832b3d55..286e7a6f528048a3259136c6637e58d9bc6262a1 100644

--- a/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc

+++ b/third_party/crashpad/crashpad/snapshot/win/exception_snapshot_win_test.cc

@@ -148,7 +148,7 @@ void TestCrashingChild(const base::string16& directory_modification) {

L"_crashing_child.exe")

.value();

ChildLauncher child(child_test_executable, pipe_name);

- child.Start();

+ ASSERT_NO_FATAL_FAILURE(child.Start());

// The child tells us (approximately) where it will crash.

WinVMAddress break_near_address;

@@ -256,7 +256,7 @@ void TestDumpWithoutCrashingChild(

L"_dump_without_crashing.exe")

.value();

ChildLauncher child(child_test_executable, pipe_name);

- child.Start();

+ ASSERT_NO_FATAL_FAILURE(child.Start());

// The child tells us (approximately) where it will capture a dump.

WinVMAddress dump_near_address;