Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1097)

Unified Diff: chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc

Issue 2833523002: Adding opt out and previews type information to DRP pingback (Closed)
Patch Set: moved definition up Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc
index 8ee9a0ad07ce949b84168b5615ebab2e3c6dde4c..7bb0c080e5e246f0b32dbc670d9ade08fdcf0779 100644
--- a/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc
@@ -71,19 +71,19 @@ class TabRestorePageLoadMetricsObserverTest
page_load_metrics::ExtraRequestInfo resources[] = {
// Cached request.
{true /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
- false /* data_reduction_proxy_used*/,
+ false /* data_reduction_proxy_used*/, false /* was_lofi_response */,
bengr 2017/04/20 17:36:18 two spaces.
RyanSturm 2017/04/20 20:25:44 Acknowledged.
0 /* original_network_content_length */},
// Uncached non-proxied request.
{false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
- false /* data_reduction_proxy_used*/,
+ false /* data_reduction_proxy_used*/, false /* was_lofi_response */,
bengr 2017/04/20 17:36:18 why no tests for was_lofi_response == true?
RyanSturm 2017/04/20 20:25:44 See other response.
1024 * 40 /* original_network_content_length */},
// Uncached proxied request with .1 compression ratio.
{false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
- false /* data_reduction_proxy_used*/,
+ false /* data_reduction_proxy_used*/, false /* was_lofi_response */,
1024 * 40 /* original_network_content_length */},
// Uncached proxied request with .5 compression ratio.
{false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
- false /* data_reduction_proxy_used*/,
+ false /* data_reduction_proxy_used*/, false /* was_lofi_response */,
1024 * 40 /* original_network_content_length */},
};

Powered by Google App Engine
This is Rietveld 408576698