Adding opt out and previews type information to DRP pingback

chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc

Index: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
index d16bcd463d323fc90a9980ef5b0fc7dc19767d19..01cbbfde93d4938531e1102d5cff2aae73ec8890 100644
--- a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
@@ -142,10 +142,10 @@ TEST_F(SubresourceFilterMetricsObserverTest, Basic) {
 TEST_F(SubresourceFilterMetricsObserverTest, Subresources) {
   NavigateAndCommit(GURL(kDefaultTestUrl));
 
-  SimulateLoadedResource({false /* was_cached */,
-                          1024 * 40 /* raw_body_bytes */,
-                          false /* data_reduction_proxy_used */,
-                          0 /* original_network_content_length */});
+  SimulateLoadedResource(
+      {false /* was_cached */, 1024 * 40 /* raw_body_bytes */,
+       false /* data_reduction_proxy_used */, false /* was_lofi_response */,
+       0 /* original_network_content_length */});
 
   page_load_metrics::PageLoadTiming timing;
   timing.navigation_start = base::Time::FromDoubleT(1);
@@ -154,13 +154,14 @@ TEST_F(SubresourceFilterMetricsObserverTest, Subresources) {
       blink::WebLoadingBehaviorFlag::kWebLoadingBehaviorSubresourceFilterMatch;
   SimulateTimingAndMetadataUpdate(timing, metadata);
 
-  SimulateLoadedResource({false /* was_cached */,
-                          1024 * 20 /* raw_body_bytes */,
-                          false /* data_reduction_proxy_used */,
-                          0 /* original_network_content_length */});
+  SimulateLoadedResource(
+      {false /* was_cached */, 1024 * 20 /* raw_body_bytes */,
+       false /* data_reduction_proxy_used */, false /* was_lofi_response */,
+       0 /* original_network_content_length */});
 
   SimulateLoadedResource({true /* was_cached */, 1024 * 10 /* raw_body_bytes */,
                           false /* data_reduction_proxy_used */,
+                          false /* was_lofi_response */,
                           0 /* original_network_content_length */});
 
   histogram_tester().ExpectTotalCount(
@@ -237,10 +238,10 @@ TEST_F(SubresourceFilterMetricsObserverTest, SubresourcesWithMedia) {
 
   SimulateMediaPlayed();
 
-  SimulateLoadedResource({false /* was_cached */,
-                          1024 * 40 /* raw_body_bytes */,
-                          false /* data_reduction_proxy_used */,
-                          0 /* original_network_content_length */});
+  SimulateLoadedResource(
+      {false /* was_cached */, 1024 * 40 /* raw_body_bytes */,
+       false /* data_reduction_proxy_used */, false /* was_lofi_response */,
+       0 /* original_network_content_length */});
 
   page_load_metrics::PageLoadTiming timing;
   timing.navigation_start = base::Time::FromDoubleT(1);
@@ -249,13 +250,14 @@ TEST_F(SubresourceFilterMetricsObserverTest, SubresourcesWithMedia) {
       blink::WebLoadingBehaviorFlag::kWebLoadingBehaviorSubresourceFilterMatch;
   SimulateTimingAndMetadataUpdate(timing, metadata);
 
-  SimulateLoadedResource({false /* was_cached */,
-                          1024 * 20 /* raw_body_bytes */,
-                          false /* data_reduction_proxy_used */,
-                          0 /* original_network_content_length */});
+  SimulateLoadedResource(
+      {false /* was_cached */, 1024 * 20 /* raw_body_bytes */,
+       false /* data_reduction_proxy_used */, false /* was_lofi_response */,
+       0 /* original_network_content_length */});
 
   SimulateLoadedResource({true /* was_cached */, 1024 * 10 /* raw_body_bytes */,
                           false /* data_reduction_proxy_used */,
+                          false /* was_lofi_response */,

[bengr, 2017/04/20 17:36:18]

Why no test coverage for was_lofi_response == true?

[RyanSturm, 2017/04/20 20:25:44]

Irrelevant and unused for this observer.

                           0 /* original_network_content_length */});
 
   histogram_tester().ExpectTotalCount(