Adding opt out and previews type information to DRP pingback

chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer.h"
 
 #include <memory>
 #include <string>
 
 #include "base/macros.h"
@@ skipping 53 matching lines @@
 
   void SimulatePageLoad(bool is_restore, bool simulate_app_background) {
     is_restore_ = is_restore;
     NavigateAndCommit(GURL(kDefaultTestUrl));
     SimulateTimingUpdate(timing_);
 
     // Prepare 4 resources of varying size and configurations.
     page_load_metrics::ExtraRequestInfo resources[] = {
         // Cached request.
         {true /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
-         false /* data_reduction_proxy_used*/,
+         false /* data_reduction_proxy_used*/, false /*  was_lofi_response */,

[bengr, 2017/04/20 17:36:18]

two spaces.

[RyanSturm, 2017/04/20 20:25:44]

Acknowledged.

          0 /* original_network_content_length */},
         // Uncached non-proxied request.
         {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
-         false /* data_reduction_proxy_used*/,
+         false /* data_reduction_proxy_used*/, false /*  was_lofi_response */,

[bengr, 2017/04/20 17:36:18]

why no tests for was_lofi_response == true?

[RyanSturm, 2017/04/20 20:25:44]

See other response.

          1024 * 40 /* original_network_content_length */},
         // Uncached proxied request with .1 compression ratio.
         {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
-         false /* data_reduction_proxy_used*/,
+         false /* data_reduction_proxy_used*/, false /*  was_lofi_response */,
          1024 * 40 /* original_network_content_length */},
         // Uncached proxied request with .5 compression ratio.
         {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
-         false /* data_reduction_proxy_used*/,
+         false /* data_reduction_proxy_used*/, false /*  was_lofi_response */,
          1024 * 40 /* original_network_content_length */},
     };
 
     for (auto request : resources) {
       SimulateLoadedResource(request);
       if (!request.was_cached) {
         network_bytes_ += request.raw_body_bytes;
       } else {
         cache_bytes_ += request.raw_body_bytes;
       }
@@ skipping 55 matching lines @@
   histogram_tester().ExpectUniqueSample(
       "PageLoad.Clients.TabRestore.Experimental.Bytes.Network",
       static_cast<int>(network_bytes_ / 1024), 1);
   histogram_tester().ExpectUniqueSample(
       "PageLoad.Clients.TabRestore.Experimental.Bytes.Cache",
       static_cast<int>(cache_bytes_ / 1024), 1);
   histogram_tester().ExpectUniqueSample(
       "PageLoad.Clients.TabRestore.Experimental.Bytes.Total",
       static_cast<int>((network_bytes_ + cache_bytes_) / 1024), 1);
 }