Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4001)

Unified Diff: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h

Issue 2833523002: Adding opt out and previews type information to DRP pingback (Closed)
Patch Set: moved definition up Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
index 19b92c1153753e1f17a4b109bca716604b9682c2..5a69ab7bf84deb05ecddf4c9709591ea8927ade7 100644
--- a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
@@ -110,7 +110,8 @@ class DataReductionProxyMetricsObserver
private:
// Sends the page load information to the pingback client.
void SendPingback(const page_load_metrics::PageLoadTiming& timing,
- const page_load_metrics::PageLoadExtraInfo& info);
+ const page_load_metrics::PageLoadExtraInfo& info,
+ bool app_background_occured);
bengr 2017/04/20 01:02:33 spelling.
RyanSturm 2017/04/20 20:25:44 Done.
// Records UMA of page size when the observer is about to be deleted.
void RecordPageSizeUMA() const;
@@ -140,6 +141,9 @@ class DataReductionProxyMetricsObserver
// The total network bytes used.
int64_t network_bytes_;
+ // A key that relates to the tab.
bengr 2017/04/20 17:36:18 relates how? uniquely identifies? why does the obs
RyanSturm 2017/04/20 20:25:44 Acknowledged.
+ void* tab_identifier_key_;
+
DISALLOW_COPY_AND_ASSIGN(DataReductionProxyMetricsObserver);
};

Powered by Google App Engine
This is Rietveld 408576698