Adding opt out and previews type information to DRP pingback

chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_OBSERVER_H_
 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_OBSERVER_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 92 matching lines @@
   void OnParseStart(const page_load_metrics::PageLoadTiming& timing,
                     const page_load_metrics::PageLoadExtraInfo& info) override;
   void OnParseStop(const page_load_metrics::PageLoadTiming& timing,
                    const page_load_metrics::PageLoadExtraInfo& info) override;
   void OnLoadedResource(
       const page_load_metrics::ExtraRequestInfo& extra_request_info) override;
 
  private:
   // Sends the page load information to the pingback client.
   void SendPingback(const page_load_metrics::PageLoadTiming& timing,
-                    const page_load_metrics::PageLoadExtraInfo& info);
+                    const page_load_metrics::PageLoadExtraInfo& info,
+                    bool app_background_occured);

[bengr, 2017/04/20 01:02:33]

spelling.

[RyanSturm, 2017/04/20 20:25:44]

Done.

 
   // Records UMA of page size when the observer is about to be deleted.
   void RecordPageSizeUMA() const;
 
   // Gets the default DataReductionProxyPingbackClient. Overridden in testing.
   virtual DataReductionProxyPingbackClient* GetPingbackClient() const;
 
   // Data related to this navigation.
   std::unique_ptr<DataReductionProxyData> data_;
 
   // The browser context this navigation is operating in.
   content::BrowserContext* browser_context_;
 
   // The number of resources that used data reduction proxy.
   int num_data_reduction_proxy_resources_;
 
   // The number of resources that did not come from cache.
   int num_network_resources_;
 
   // The total content network bytes that the user would have downloaded if they
   // were not using data reduction proxy.
   int64_t original_network_bytes_;
 
   // The total network bytes loaded through data reduction proxy.
   int64_t network_bytes_proxied_;
 
   // The total network bytes used.
   int64_t network_bytes_;
 
+  // A key that relates to the tab.

[bengr, 2017/04/20 17:36:18]

relates how? uniquely identifies? why does the observer need tab identification?

[RyanSturm, 2017/04/20 20:25:44]

Acknowledged.

+  void* tab_identifier_key_;
+
   DISALLOW_COPY_AND_ASSIGN(DataReductionProxyMetricsObserver);
 };
 
 }  // namespace data_reduction_proxy
 
 #endif  // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_OBSERVER_H_