Adding opt out and previews type information to DRP pingback

chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
index 84501e03c35c3b57257d02b5686af17248634277..37e2c0e1d83f69884cf948cc61ac73bca6c16aa2 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
@@ -413,11 +413,11 @@ TEST_F(CorePageLoadMetricsObserverTest, Reload) {
   page_load_metrics::ExtraRequestInfo resources[] = {
       // Cached request.
       {true /*was_cached*/, 1024 * 20 /* raw_body_bytes */,
-       false /* data_reduction_proxy_used*/,
+       false /* data_reduction_proxy_used*/, false /*  was_lofi_response */,

[bengr, 2017/04/20 17:36:18]

Nit: Remove the extra space in the comments here and below.

[RyanSturm, 2017/04/20 20:25:44]

Acknowledged.

        0 /* original_network_content_length */},
       // Uncached non-proxied request.
       {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
-       false /* data_reduction_proxy_used*/,
+       false /* data_reduction_proxy_used*/, false /*  was_lofi_response */,

[bengr, 2017/04/20 17:36:18]

Why are there no core page load metrics observer tests that cover
was_lofi_response == true?

[RyanSturm, 2017/04/20 20:25:44]

These are unused in most observers. I switched to DRPData, let me know if you
want me to run a few extra requests for DRPData.

        1024 * 40 /* original_network_content_length */},
   };
 
@@ -498,11 +498,11 @@ TEST_F(CorePageLoadMetricsObserverTest, ForwardBack) {
   page_load_metrics::ExtraRequestInfo resources[] = {
       // Cached request.
       {true /*was_cached*/, 1024 * 20 /* raw_body_bytes */,
-       false /* data_reduction_proxy_used*/,
+       false /* data_reduction_proxy_used*/, false /*  was_lofi_response */,
        0 /* original_network_content_length */},
       // Uncached non-proxied request.
       {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
-       false /* data_reduction_proxy_used*/,
+       false /* data_reduction_proxy_used*/, false /*  was_lofi_response */,
        1024 * 40 /* original_network_content_length */},
   };
 
@@ -577,11 +577,11 @@ TEST_F(CorePageLoadMetricsObserverTest, NewNavigation) {
   page_load_metrics::ExtraRequestInfo resources[] = {
       // Cached request.
       {true /*was_cached*/, 1024 * 20 /* raw_body_bytes */,
-       false /* data_reduction_proxy_used*/,
+       false /* data_reduction_proxy_used*/, false /*  was_lofi_response */,
        0 /* original_network_content_length */},
       // Uncached non-proxied request.
       {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
-       false /* data_reduction_proxy_used*/,
+       false /* data_reduction_proxy_used*/, false /*  was_lofi_response */,
        1024 * 40 /* original_network_content_length */},
   };