Adding opt out and previews type information to DRP pingback

chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h"
 
 #include "base/memory/ptr_util.h"
 #include "chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h"
 #include "chrome/browser/page_load_metrics/page_load_metrics_util.h"
 #include "chrome/test/base/testing_browser_process.h"
@@ skipping 395 matching lines @@
   timing.first_contentful_paint = base::TimeDelta::FromMilliseconds(10);
   PopulateRequiredTimingFields(&timing);
 
   GURL url(kDefaultTestUrl);
   NavigateWithPageTransitionAndCommit(url, ui::PAGE_TRANSITION_RELOAD);
   SimulateTimingUpdate(timing);
 
   page_load_metrics::ExtraRequestInfo resources[] = {
       // Cached request.
       {true /*was_cached*/, 1024 * 20 /* raw_body_bytes */,
-       false /* data_reduction_proxy_used*/,
+       false /* data_reduction_proxy_used*/, false /*  was_lofi_response */,

[bengr, 2017/04/20 17:36:18]

Nit: Remove the extra space in the comments here and below.

[RyanSturm, 2017/04/20 20:25:44]

Acknowledged.

        0 /* original_network_content_length */},
       // Uncached non-proxied request.
       {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
-       false /* data_reduction_proxy_used*/,
+       false /* data_reduction_proxy_used*/, false /*  was_lofi_response */,

[bengr, 2017/04/20 17:36:18]

Why are there no core page load metrics observer tests that cover
was_lofi_response == true?

[RyanSturm, 2017/04/20 20:25:44]

These are unused in most observers. I switched to DRPData, let me know if you
want me to run a few extra requests for DRPData.

        1024 * 40 /* original_network_content_length */},
   };
 
   int64_t network_bytes = 0;
   int64_t cache_bytes = 0;
   for (const auto& request : resources) {
     SimulateLoadedResource(request);
     if (!request.was_cached) {
       network_bytes += request.raw_body_bytes;
     } else {
@@ skipping 60 matching lines @@
   // modifier. This test verifies that when we encounter such a page, we log it
   // as a forward/back navigation.
   NavigateWithPageTransitionAndCommit(
       url, ui::PageTransitionFromInt(ui::PAGE_TRANSITION_RELOAD |
                                      ui::PAGE_TRANSITION_FORWARD_BACK));
   SimulateTimingUpdate(timing);
 
   page_load_metrics::ExtraRequestInfo resources[] = {
       // Cached request.
       {true /*was_cached*/, 1024 * 20 /* raw_body_bytes */,
-       false /* data_reduction_proxy_used*/,
+       false /* data_reduction_proxy_used*/, false /*  was_lofi_response */,
        0 /* original_network_content_length */},
       // Uncached non-proxied request.
       {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
-       false /* data_reduction_proxy_used*/,
+       false /* data_reduction_proxy_used*/, false /*  was_lofi_response */,
        1024 * 40 /* original_network_content_length */},
   };
 
   int64_t network_bytes = 0;
   int64_t cache_bytes = 0;
   for (const auto& request : resources) {
     SimulateLoadedResource(request);
     if (!request.was_cached) {
       network_bytes += request.raw_body_bytes;
     } else {
@@ skipping 54 matching lines @@
   timing.first_contentful_paint = base::TimeDelta::FromMilliseconds(10);
   PopulateRequiredTimingFields(&timing);
 
   GURL url(kDefaultTestUrl);
   NavigateWithPageTransitionAndCommit(url, ui::PAGE_TRANSITION_LINK);
   SimulateTimingUpdate(timing);
 
   page_load_metrics::ExtraRequestInfo resources[] = {
       // Cached request.
       {true /*was_cached*/, 1024 * 20 /* raw_body_bytes */,
-       false /* data_reduction_proxy_used*/,
+       false /* data_reduction_proxy_used*/, false /*  was_lofi_response */,
        0 /* original_network_content_length */},
       // Uncached non-proxied request.
       {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
-       false /* data_reduction_proxy_used*/,
+       false /* data_reduction_proxy_used*/, false /*  was_lofi_response */,
        1024 * 40 /* original_network_content_length */},
   };
 
   int64_t network_bytes = 0;
   int64_t cache_bytes = 0;
   for (auto request : resources) {
     SimulateLoadedResource(request);
     if (!request.was_cached) {
       network_bytes += request.raw_body_bytes;
     } else {
@@ skipping 103 matching lines @@
   NavigateAndCommit(GURL(kDefaultTestUrl2));
 
   histogram_tester().ExpectTotalCount(
       internal::kHistogramFirstMeaningfulPaint, 0);
   histogram_tester().ExpectTotalCount(
       internal::kHistogramParseStartToFirstMeaningfulPaint, 0);
   histogram_tester().ExpectBucketCount(
       internal::kHistogramFirstMeaningfulPaintStatus,
       internal::FIRST_MEANINGFUL_PAINT_USER_INTERACTION_BEFORE_FMP, 1);
 }