Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2833453002: Revert of Disable WebRtcVideoQualityBrowserTest on Mac (Closed)

Created:
3 years, 8 months ago by Max Morin
Modified:
3 years, 8 months ago
Reviewers:
emircan, Nico, hbos_chromium
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, phoglund+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable WebRtcVideoQualityBrowserTest on Mac (patchset #2 id:20001 of https://codereview.chromium.org/2821533002/ ) Reason for revert: Reenabling the test since the log spam is fixed. Original issue's description: > Disable WebRtcVideoQualityBrowserTest on Mac > > BUG=711400 > > Review-Url: https://codereview.chromium.org/2821533002 > Cr-Commit-Position: refs/heads/master@{#465528} > Committed: https://chromium.googlesource.com/chromium/src/+/896daeca6982c6250e36660df8f957fbb01437b0 TBR=thakis@chromium.org,hbos@chromium.org,emircan@chromium.org BUG=711400 Review-Url: https://codereview.chromium.org/2833453002 Cr-Commit-Position: refs/heads/master@{#465595} Committed: https://chromium.googlesource.com/chromium/src/+/256eeddadb58f87e4be50dff04f81e3adf451a77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M chrome/browser/media/webrtc/webrtc_video_quality_browsertest.cc View 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Max Morin
Created Revert of Disable WebRtcVideoQualityBrowserTest on Mac
3 years, 8 months ago (2017-04-19 13:41:59 UTC) #1
Nico
lgtm Do you have a link to the CL fixing the logspam?
3 years, 8 months ago (2017-04-19 13:47:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833453002/1
3 years, 8 months ago (2017-04-19 13:48:17 UTC) #5
Nico
nvm, it's in the bug: https://codereview.chromium.org/2822123002
3 years, 8 months ago (2017-04-19 13:48:23 UTC) #7
Max Morin
On 2017/04/19 13:48:23, Nico wrote: > nvm, it's in the bug: https://codereview.chromium.org/2822123002 Thanks. I also ...
3 years, 8 months ago (2017-04-19 13:49:47 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 14:26:34 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/256eeddadb58f87e4be50dff04f8...

Powered by Google App Engine
This is Rietveld 408576698