Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2821533002: Disable WebRtcVideoQualityBrowserTest on Mac (Closed)

Created:
3 years, 8 months ago by emircan
Modified:
3 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, phoglund+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable WebRtcVideoQualityBrowserTest on Mac BUG=711400 Review-Url: https://codereview.chromium.org/2821533002 Cr-Commit-Position: refs/heads/master@{#465528} Committed: https://chromium.googlesource.com/chromium/src/+/896daeca6982c6250e36660df8f957fbb01437b0

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/browser/media/webrtc/webrtc_video_quality_browsertest.cc View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
emircan
PTAL. This Cl disables the failing tests.
3 years, 8 months ago (2017-04-13 20:46:49 UTC) #4
Nico
Is this a new test failure caused by some recent check-in? If so, can we ...
3 years, 8 months ago (2017-04-13 20:48:50 UTC) #5
emircan
On 2017/04/13 20:48:50, Nico wrote: > Is this a new test failure caused by some ...
3 years, 8 months ago (2017-04-13 20:53:49 UTC) #6
hbos_chromium
lgtm
3 years, 8 months ago (2017-04-18 08:13:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2821533002/20001
3 years, 8 months ago (2017-04-19 07:33:02 UTC) #15
Max Morin
I'm committing this as the bot is red right now.
3 years, 8 months ago (2017-04-19 07:33:32 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/896daeca6982c6250e36660df8f957fbb01437b0
3 years, 8 months ago (2017-04-19 08:14:52 UTC) #19
Max Morin
3 years, 8 months ago (2017-04-19 13:41:58 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2833453002/ by maxmorin@chromium.org.

The reason for reverting is: Reenabling the test since the log spam is fixed..

Powered by Google App Engine
This is Rietveld 408576698