Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2833423004: [turbofan] Make sure an inlined call is not resurrected and inlined again. (Closed)

Created:
3 years, 8 months ago by Jarin
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com, Benedikt Meurer
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make sure an inlined call is not resurrected and inlined again. BUG=chromium:714483 Review-Url: https://codereview.chromium.org/2833423004 Cr-Commit-Position: refs/heads/master@{#44830} Committed: https://chromium.googlesource.com/v8/v8/+/d081a6f692f0fc7ecbca40f09b07eebbbdb8c43d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M src/compiler/js-inlining.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/js-inlining-heuristic.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/regress-714483.js View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Jarin
Could you take a look, please? (Thanks for helping me to hunt this down!)
3 years, 8 months ago (2017-04-24 18:49:36 UTC) #4
Benedikt Meurer
Nice, LGTM! Thanks for fixing.
3 years, 8 months ago (2017-04-24 18:53:58 UTC) #6
Michael Starzinger
LGTM. Nice. Thanks!
3 years, 8 months ago (2017-04-25 08:08:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833423004/1
3 years, 8 months ago (2017-04-25 08:09:14 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 08:10:40 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d081a6f692f0fc7ecbca40f09b07eebbbdb...

Powered by Google App Engine
This is Rietveld 408576698