Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: src/compiler/js-inlining-heuristic.cc

Issue 2833423004: [turbofan] Make sure an inlined call is not resurrected and inlined again. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-inlining.cc ('k') | test/mjsunit/compiler/regress-714483.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-inlining-heuristic.cc
diff --git a/src/compiler/js-inlining-heuristic.cc b/src/compiler/js-inlining-heuristic.cc
index d86f8b62effe58fd031ecc79ac71149299352e68..9774de28e5f23911e4e1ac1950ce63060fbe73e4 100644
--- a/src/compiler/js-inlining-heuristic.cc
+++ b/src/compiler/js-inlining-heuristic.cc
@@ -270,6 +270,9 @@ Reduction JSInliningHeuristic::InlineCandidate(Candidate const& candidate) {
Node* node = calls[i];
Reduction const reduction = inliner_.ReduceJSCall(node);
if (reduction.Changed()) {
+ // Killing the call node is not strictly necessary, but it is safer to
+ // make sure we do not resurrect the node.
+ node->Kill();
cumulative_count_ += function->shared()->ast_node_count();
}
}
« no previous file with comments | « src/compiler/js-inlining.cc ('k') | test/mjsunit/compiler/regress-714483.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698