Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2833423002: Added WebStateImpl::OnNavigationFinished(). (Closed)

Created:
3 years, 8 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 7 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Added WebStateImpl::OnNavigationFinished(). This CL (4 of 7) is a part of large refactoring to create NavigationContext when navigation was started, not when it is finished. This refactoring will allow to pass the same instance of NavigationContext to DidStartNavigation and DidFinishNavigation (crbug.com/713836). Also this will allow to associate NavigationItem with NavigationContext object to commit non-latest navigation (crbug.com/712269). This CL adds WebStateimpl::OnNavigationFinished which simply calls WebStateObserver::DidFinishNavigation. This method will be used to pass NavigationContext (which will be created earlier) to DidFinishNavigation. BUG=713836, 712269 Review-Url: https://codereview.chromium.org/2833423002 Cr-Commit-Position: refs/heads/master@{#470314} Committed: https://chromium.googlesource.com/chromium/src/+/1000a00b446127c2c0148fe11b2bf2b8223e85b4

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -15 lines) Patch
M ios/web/web_state/web_state_impl.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_impl.mm View 1 1 chunk +5 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_impl_unittest.mm View 4 chunks +33 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Eugene But (OOO till 7-30)
3 years, 8 months ago (2017-04-24 14:10:25 UTC) #4
kkhorimoto
lgtm
3 years, 8 months ago (2017-04-25 13:47:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833423002/20001
3 years, 7 months ago (2017-05-09 13:40:26 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 13:52:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1000a00b446127c2c0148fe11b2b...

Powered by Google App Engine
This is Rietveld 408576698