Added WebStateImpl::OnNavigationFinished().

ios/web/web_state/web_state_impl_unittest.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/web/web_state/web_state_impl.h"
 
 #include <stddef.h>
 
 #include <memory>
 
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/logging.h"
 #import "base/mac/bind_objc_block.h"
 #include "base/memory/ptr_util.h"
 #import "base/test/ios/wait_util.h"
 #import "ios/web/public/java_script_dialog_presenter.h"
 #include "ios/web/public/load_committed_details.h"
 #include "ios/web/public/test/fakes/test_browser_state.h"
 #import "ios/web/public/test/fakes/test_web_state_delegate.h"
 #import "ios/web/public/test/fakes/test_web_state_observer.h"
 #include "ios/web/public/test/web_test.h"
 #import "ios/web/public/web_state/context_menu_params.h"
 #include "ios/web/public/web_state/global_web_state_observer.h"
 #include "ios/web/public/web_state/navigation_context.h"
 #import "ios/web/public/web_state/web_state_delegate.h"
 #include "ios/web/public/web_state/web_state_observer.h"
 #import "ios/web/public/web_state/web_state_policy_decider.h"
 #include "ios/web/web_state/global_web_state_event_tracker.h"
+#include "ios/web/web_state/navigation_context_impl.h"
 #import "ios/web/web_state/ui/crw_web_controller.h"
 #include "net/http/http_response_headers.h"
 #include "net/http/http_util.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #import "testing/gtest_mac.h"
 #include "url/gurl.h"
 
 using testing::_;
 using testing::Assign;
@@ skipping 300 matching lines @@
             actual_favicon_url.icon_sizes[0].height());
 
   // Test that RenderProcessGone() is called.
   SetIgnoreRenderProcessCrashesDuringTesting(true);
   ASSERT_FALSE(observer->render_process_gone_info());
   web_state_->OnRenderProcessGone();
   ASSERT_TRUE(observer->render_process_gone_info());
   EXPECT_EQ(web_state_.get(), observer->render_process_gone_info()->web_state);
 
   // Test that ProvisionalNavigationStarted() is called.
+  ASSERT_FALSE(observer->did_finish_navigation_info());
+  const GURL url("http://test");
+  std::unique_ptr<web::NavigationContext> context =
+      NavigationContextImpl::CreateNavigationContext(
+          web_state_.get(), url, nullptr /* response_headers */);
+  web_state_->OnNavigationFinished(context.get());
+  ASSERT_TRUE(observer->did_finish_navigation_info());
+  EXPECT_EQ(web_state_.get(),
+            observer->did_finish_navigation_info()->web_state);
+  NavigationContext* actual_context =
+      observer->did_finish_navigation_info()->context.get();
+  EXPECT_EQ(context->GetUrl(), actual_context->GetUrl());
+  EXPECT_FALSE(actual_context->IsSameDocument());
+  EXPECT_FALSE(actual_context->IsErrorPage());
+  EXPECT_FALSE(actual_context->GetResponseHeaders());
+
+  // Test that OnNavigationFinished() is called.
   ASSERT_FALSE(observer->start_provisional_navigation_info());
-  const GURL url("http://test");
   web_state_->OnProvisionalNavigationStarted(url);
   ASSERT_TRUE(observer->start_provisional_navigation_info());
   EXPECT_EQ(web_state_.get(),
             observer->start_provisional_navigation_info()->web_state);
   EXPECT_EQ(url, observer->start_provisional_navigation_info()->url);
 
   // Test that NavigationItemsPruned() is called.
   ASSERT_FALSE(observer->navigation_items_pruned_info());
   web_state_->OnNavigationItemsPruned(1);
   ASSERT_TRUE(observer->navigation_items_pruned_info());
@@ skipping 24 matching lines @@
   ASSERT_FALSE(observer->load_page_info());
   web_state_->OnPageLoaded(url, false);
   ASSERT_TRUE(observer->load_page_info());
   EXPECT_EQ(web_state_.get(), observer->load_page_info()->web_state);
   EXPECT_FALSE(observer->load_page_info()->success);
   web_state_->OnPageLoaded(url, true);
   ASSERT_TRUE(observer->load_page_info());
   EXPECT_EQ(web_state_.get(), observer->load_page_info()->web_state);
   EXPECT_TRUE(observer->load_page_info()->success);
 
-  // Test that DidFinishNavigation() is called for same document navigations.
+  // Reset the observer and test that DidFinishNavigation() is called
+  // for same document navigations.
+  observer = base::MakeUnique<TestWebStateObserver>(web_state_.get());
   ASSERT_FALSE(observer->did_finish_navigation_info());
   web_state_->OnSameDocumentNavigation(url);
   ASSERT_TRUE(observer->did_finish_navigation_info());
   EXPECT_EQ(web_state_.get(),
             observer->did_finish_navigation_info()->web_state);
-  NavigationContext* context =
-      observer->did_finish_navigation_info()->context.get();
-  ASSERT_TRUE(context);
-  EXPECT_EQ(url, context->GetUrl());
-  EXPECT_TRUE(context->IsSameDocument());
-  EXPECT_FALSE(context->IsErrorPage());
-  EXPECT_FALSE(context->GetResponseHeaders());
+  actual_context = observer->did_finish_navigation_info()->context.get();
+  ASSERT_TRUE(actual_context);
+  EXPECT_EQ(url, actual_context->GetUrl());
+  EXPECT_TRUE(actual_context->IsSameDocument());
+  EXPECT_FALSE(actual_context->IsErrorPage());
+  EXPECT_FALSE(actual_context->GetResponseHeaders());
 
   // Reset the observer and test that DidFinishNavigation() is called
   // for error navigations.
   observer = base::MakeUnique<TestWebStateObserver>(web_state_.get());
   ASSERT_FALSE(observer->did_finish_navigation_info());
   web_state_->OnErrorPageNavigation(url);
   ASSERT_TRUE(observer->did_finish_navigation_info());
   EXPECT_EQ(web_state_.get(),
             observer->did_finish_navigation_info()->web_state);
-  context = observer->did_finish_navigation_info()->context.get();
-  ASSERT_TRUE(context);
-  EXPECT_EQ(url, context->GetUrl());
-  EXPECT_FALSE(context->IsSameDocument());
-  EXPECT_TRUE(context->IsErrorPage());
-  EXPECT_FALSE(context->GetResponseHeaders());
+  actual_context = observer->did_finish_navigation_info()->context.get();
+  ASSERT_TRUE(actual_context);
+  EXPECT_EQ(url, actual_context->GetUrl());
+  EXPECT_FALSE(actual_context->IsSameDocument());
+  EXPECT_TRUE(actual_context->IsErrorPage());
+  EXPECT_FALSE(actual_context->GetResponseHeaders());
 
   // Test that OnTitleChanged() is called.
   ASSERT_FALSE(observer->title_was_set_info());
   web_state_->OnTitleChanged();
   ASSERT_TRUE(observer->title_was_set_info());
   EXPECT_EQ(web_state_.get(), observer->title_was_set_info()->web_state);
 
   // Test that WebStateDestroyed() is called.
   EXPECT_FALSE(observer->web_state_destroyed_info());
   web_state_.reset();
@@ skipping 261 matching lines @@
   // Set |created_with_opener| to true and verify that HasOpener() returns true.
   WebState::CreateParams params_with_opener =
       WebState::CreateParams(GetBrowserState());
   params_with_opener.created_with_opener = true;
   std::unique_ptr<WebState> web_state_with_opener =
       WebState::Create(params_with_opener);
   EXPECT_TRUE(web_state_with_opener->HasOpener());
 }
 
 }  // namespace web