Fix unsafe destruction order of InputDeviceFactoryEvdev

Fix unsafe destruction order of InputDeviceFactoryEvdev

This was never destroyed prior to 60a7c584a9be ("mash: Don't synthesize
extra key press events in the window server").

Now it's destroyed in a couple places, so try to make this safe.
Particularly, destroy devices prior to shared state such as the gestures
properties object, and make devices stop DCHECKing that they are
destroyed gently (i.e., by getting disabled and stopped from the hotplug
handler). Shutdown destruction is abrupt.

This should fix a couple issues people are seeing since we started
calling the destructor (at least the input related ones).

BUG=711431, 713624, 713968
TEST=just compile

Review-Url: https://codereview.chromium.org/2828843002
Cr-Commit-Position: refs/heads/master@{#466336}
(cherry picked from commit 419dd2a3447f1d39c092f4259d87906c192ed0da)

Review-Url: https://codereview.chromium.org/2833243002 .
Cr-Commit-Position: refs/branch-heads/3071@{#140}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/955a01b06b3cb7fb6ca51acd085313439c0ef5bb

[marcheu1, 2017-04-22 01:36:27]

Description was changed from

==========
Fix unsafe destruction order of InputDeviceFactoryEvdev

This was never destroyed prior to 60a7c584a9be ("mash: Don't synthesize
extra key press events in the window server").

Now it's destroyed in a couple places, so try to make this safe.
Particularly, destroy devices prior to shared state such as the gestures
properties object, and make devices stop DCHECKing that they are
destroyed gently (i.e., by getting disabled and stopped from the hotplug
handler). Shutdown destruction is abrupt.

This should fix a couple issues people are seeing since we started
calling the destructor (at least the input related ones).

BUG=711431, 713624, 713968
TEST=just compile

Review-Url: https://codereview.chromium.org/2828843002
Cr-Commit-Position: refs/heads/master@{#466336}
(cherry picked from commit 419dd2a3447f1d39c092f4259d87906c192ed0da)
==========

to

==========
Fix unsafe destruction order of InputDeviceFactoryEvdev

This was never destroyed prior to 60a7c584a9be ("mash: Don't synthesize
extra key press events in the window server").

Now it's destroyed in a couple places, so try to make this safe.
Particularly, destroy devices prior to shared state such as the gestures
properties object, and make devices stop DCHECKing that they are
destroyed gently (i.e., by getting disabled and stopped from the hotplug
handler). Shutdown destruction is abrupt.

This should fix a couple issues people are seeing since we started
calling the destructor (at least the input related ones).

BUG=711431, 713624, 713968
TEST=just compile

Review-Url: https://codereview.chromium.org/2828843002
Cr-Commit-Position: refs/heads/master@{#466336}
(cherry picked from commit 419dd2a3447f1d39c092f4259d87906c192ed0da)

Review-Url: https://codereview.chromium.org/2833243002 .
Cr-Commit-Position: refs/branch-heads/3071@{#140}
Cr-Branched-From:
a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed:
https://chromium.googlesource.com/chromium/src/+/955a01b06b3cb7fb6ca51acd0853...
==========

[marcheu1, 2017-04-22 01:36:28]

Committed patchset #1 (id:1) manually as
955a01b06b3cb7fb6ca51acd085313439c0ef5bb.