Fix unsafe destruction order of InputDeviceFactoryEvdev

Fix unsafe destruction order of InputDeviceFactoryEvdev

This was never destroyed prior to 60a7c584a9be ("mash: Don't synthesize
extra key press events in the window server").

Now it's destroyed in a couple places, so try to make this safe.
Particularly, destroy devices prior to shared state such as the gestures
properties object, and make devices stop DCHECKing that they are
destroyed gently (i.e., by getting disabled and stopped from the hotplug
handler). Shutdown destruction is abrupt.

This should fix a couple issues people are seeing since we started
calling the destructor (at least the input related ones).

BUG=711431, 713624, 713968
TEST=just compile

Review-Url: https://codereview.chromium.org/2828843002
Cr-Commit-Position: refs/heads/master@{#466336}
Committed: https://chromium.googlesource.com/chromium/src/+/419dd2a3447f1d39c092f4259d87906c192ed0da

[spang, 2017-04-19 18:19:45]

spang@chromium.org changed reviewers:
+ kpschoedel@chromium.org, rjkroege@chromium.org

[spang, 2017-04-19 18:20:08]

Description was changed from

==========
Fix unsafe destruction order of InputDeviceFactoryEvdev

This was never destroyed prior to 60a7c584a9be ("mash: Don't synthesize
extra key press events in the window server").

Now it's destroyed in a couple places, so try to make this safe.
Particularly, destroy devices prior to shared state such as the gestures
properties object, and make devices stop DCHECKing that they are
destroyed gently (i.e., by getting disabled and stopped from the hotplug
handler).

This should fix a couple issues people are seeing since we started
calling the destructor (at least the input related ones).

BUG=711431, b/37440151
TEST=just compile
==========

to

==========
Fix unsafe destruction order of InputDeviceFactoryEvdev

This was never destroyed prior to 60a7c584a9be ("mash: Don't synthesize
extra key press events in the window server").

Now it's destroyed in a couple places, so try to make this safe.
Particularly, destroy devices prior to shared state such as the gestures
properties object, and make devices stop DCHECKing that they are
destroyed gently (i.e., by getting disabled and stopped from the hotplug
handler).

This should fix a couple issues people are seeing since we started
calling the destructor (at least the input related ones).

BUG=711431,b/37440151
TEST=just compile
==========

[spang, 2017-04-19 18:20:17]

Description was changed from

==========
Fix unsafe destruction order of InputDeviceFactoryEvdev

This was never destroyed prior to 60a7c584a9be ("mash: Don't synthesize
extra key press events in the window server").

Now it's destroyed in a couple places, so try to make this safe.
Particularly, destroy devices prior to shared state such as the gestures
properties object, and make devices stop DCHECKing that they are
destroyed gently (i.e., by getting disabled and stopped from the hotplug
handler).

This should fix a couple issues people are seeing since we started
calling the destructor (at least the input related ones).

BUG=711431,b/37440151
TEST=just compile
==========

to

==========
Fix unsafe destruction order of InputDeviceFactoryEvdev

This was never destroyed prior to 60a7c584a9be ("mash: Don't synthesize
extra key press events in the window server").

Now it's destroyed in a couple places, so try to make this safe.
Particularly, destroy devices prior to shared state such as the gestures
properties object, and make devices stop DCHECKing that they are
destroyed gently (i.e., by getting disabled and stopped from the hotplug
handler).

This should fix a couple issues people are seeing since we started
calling the destructor (at least the input related ones).

BUG=711431
BUG=b/37440151
TEST=just compile
==========

[spang, 2017-04-19 18:21:18]

Description was changed from

==========
Fix unsafe destruction order of InputDeviceFactoryEvdev

This was never destroyed prior to 60a7c584a9be ("mash: Don't synthesize
extra key press events in the window server").

Now it's destroyed in a couple places, so try to make this safe.
Particularly, destroy devices prior to shared state such as the gestures
properties object, and make devices stop DCHECKing that they are
destroyed gently (i.e., by getting disabled and stopped from the hotplug
handler).

This should fix a couple issues people are seeing since we started
calling the destructor (at least the input related ones).

BUG=711431
BUG=b/37440151
TEST=just compile
==========

to

==========
Fix unsafe destruction order of InputDeviceFactoryEvdev

This was never destroyed prior to 60a7c584a9be ("mash: Don't synthesize
extra key press events in the window server").

Now it's destroyed in a couple places, so try to make this safe.
Particularly, destroy devices prior to shared state such as the gestures
properties object, and make devices stop DCHECKing that they are
destroyed gently (i.e., by getting disabled and stopped from the hotplug
handler).

This should fix a couple issues people are seeing since we started
calling the destructor (at least the input related ones).

BUG=711431, b:37440151
TEST=just compile
==========

[spang, 2017-04-19 18:22:26]

Description was changed from

==========
Fix unsafe destruction order of InputDeviceFactoryEvdev

This was never destroyed prior to 60a7c584a9be ("mash: Don't synthesize
extra key press events in the window server").

Now it's destroyed in a couple places, so try to make this safe.
Particularly, destroy devices prior to shared state such as the gestures
properties object, and make devices stop DCHECKing that they are
destroyed gently (i.e., by getting disabled and stopped from the hotplug
handler).

This should fix a couple issues people are seeing since we started
calling the destructor (at least the input related ones).

BUG=711431, b:37440151
TEST=just compile
==========

to

==========
Fix unsafe destruction order of InputDeviceFactoryEvdev

This was never destroyed prior to 60a7c584a9be ("mash: Don't synthesize
extra key press events in the window server").

Now it's destroyed in a couple places, so try to make this safe.
Particularly, destroy devices prior to shared state such as the gestures
properties object, and make devices stop DCHECKing that they are
destroyed gently (i.e., by getting disabled and stopped from the hotplug
handler). Shutdown destruction is abrupt.

This should fix a couple issues people are seeing since we started
calling the destructor (at least the input related ones).

BUG=711431, b:37440151
TEST=just compile
==========

[spang, 2017-04-19 18:23:15]

spang@chromium.org changed reviewers:
+ halliwell@chromium.org, xiyuan@chromium.org

[spang, 2017-04-19 18:23:45]

Description was changed from

==========
Fix unsafe destruction order of InputDeviceFactoryEvdev

This was never destroyed prior to 60a7c584a9be ("mash: Don't synthesize
extra key press events in the window server").

Now it's destroyed in a couple places, so try to make this safe.
Particularly, destroy devices prior to shared state such as the gestures
properties object, and make devices stop DCHECKing that they are
destroyed gently (i.e., by getting disabled and stopped from the hotplug
handler). Shutdown destruction is abrupt.

This should fix a couple issues people are seeing since we started
calling the destructor (at least the input related ones).

BUG=711431, b:37440151
TEST=just compile
==========

to

==========
Fix unsafe destruction order of InputDeviceFactoryEvdev

This was never destroyed prior to r463036 ("mash: Don't synthesize
extra key press events in the window server").

Now it's destroyed in a couple places, so try to make this safe.
Particularly, destroy devices prior to shared state such as the gestures
properties object, and make devices stop DCHECKing that they are
destroyed gently (i.e., by getting disabled and stopped from the hotplug
handler). Shutdown destruction is abrupt.

This should fix a couple issues people are seeing since we started
calling the destructor (at least the input related ones).

BUG=711431, b:37440151
TEST=just compile
==========

[spang, 2017-04-19 18:23:59]

Description was changed from

==========
Fix unsafe destruction order of InputDeviceFactoryEvdev

This was never destroyed prior to r463036 ("mash: Don't synthesize
extra key press events in the window server").

Now it's destroyed in a couple places, so try to make this safe.
Particularly, destroy devices prior to shared state such as the gestures
properties object, and make devices stop DCHECKing that they are
destroyed gently (i.e., by getting disabled and stopped from the hotplug
handler). Shutdown destruction is abrupt.

This should fix a couple issues people are seeing since we started
calling the destructor (at least the input related ones).

BUG=711431, b:37440151
TEST=just compile
==========

to

==========
Fix unsafe destruction order of InputDeviceFactoryEvdev

This was never destroyed prior to 60a7c584a9be ("mash: Don't synthesize
extra key press events in the window server").

Now it's destroyed in a couple places, so try to make this safe.
Particularly, destroy devices prior to shared state such as the gestures
properties object, and make devices stop DCHECKing that they are
destroyed gently (i.e., by getting disabled and stopped from the hotplug
handler). Shutdown destruction is abrupt.

This should fix a couple issues people are seeing since we started
calling the destructor (at least the input related ones).

BUG=711431, b:37440151
TEST=just compile
==========

[spang, 2017-04-19 18:24:12]

The CQ bit was checked by spang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 18:24:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 18:56:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 18:57:00]

Dry run: This issue passed the CQ dry run.

[spang, 2017-04-19 21:02:20]

The CQ bit was checked by spang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 21:03:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 21:28:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 21:28:49]

Dry run: This issue passed the CQ dry run.

[spang, 2017-04-20 16:05:54]

Description was changed from

==========
Fix unsafe destruction order of InputDeviceFactoryEvdev

This was never destroyed prior to 60a7c584a9be ("mash: Don't synthesize
extra key press events in the window server").

Now it's destroyed in a couple places, so try to make this safe.
Particularly, destroy devices prior to shared state such as the gestures
properties object, and make devices stop DCHECKing that they are
destroyed gently (i.e., by getting disabled and stopped from the hotplug
handler). Shutdown destruction is abrupt.

This should fix a couple issues people are seeing since we started
calling the destructor (at least the input related ones).

BUG=711431, b:37440151
TEST=just compile
==========

to

==========
Fix unsafe destruction order of InputDeviceFactoryEvdev

This was never destroyed prior to 60a7c584a9be ("mash: Don't synthesize
extra key press events in the window server").

Now it's destroyed in a couple places, so try to make this safe.
Particularly, destroy devices prior to shared state such as the gestures
properties object, and make devices stop DCHECKing that they are
destroyed gently (i.e., by getting disabled and stopped from the hotplug
handler). Shutdown destruction is abrupt.

This should fix a couple issues people are seeing since we started
calling the destructor (at least the input related ones).

BUG=711431, 713624
TEST=just compile
==========

[spang, 2017-04-20 16:06:11]

spang@chromium.org changed reviewers:
+ emaxx@chromium.org

[rjkroege, 2017-04-21 14:16:45]

lgtm

[spang, 2017-04-21 14:36:39]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2017-04-21 14:36:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[spang, 2017-04-21 14:41:19]

The CQ bit was unchecked by spang@chromium.org

[spang, 2017-04-21 14:41:28]

Description was changed from

==========
Fix unsafe destruction order of InputDeviceFactoryEvdev

This was never destroyed prior to 60a7c584a9be ("mash: Don't synthesize
extra key press events in the window server").

Now it's destroyed in a couple places, so try to make this safe.
Particularly, destroy devices prior to shared state such as the gestures
properties object, and make devices stop DCHECKing that they are
destroyed gently (i.e., by getting disabled and stopped from the hotplug
handler). Shutdown destruction is abrupt.

This should fix a couple issues people are seeing since we started
calling the destructor (at least the input related ones).

BUG=711431, 713624
TEST=just compile
==========

to

==========
Fix unsafe destruction order of InputDeviceFactoryEvdev

This was never destroyed prior to 60a7c584a9be ("mash: Don't synthesize
extra key press events in the window server").

Now it's destroyed in a couple places, so try to make this safe.
Particularly, destroy devices prior to shared state such as the gestures
properties object, and make devices stop DCHECKing that they are
destroyed gently (i.e., by getting disabled and stopped from the hotplug
handler). Shutdown destruction is abrupt.

This should fix a couple issues people are seeing since we started
calling the destructor (at least the input related ones).

BUG=711431, 713624, 713968
TEST=just compile
==========

[spang, 2017-04-21 14:41:33]

The CQ bit was checked by spang@chromium.org

[commit-bot: I haz the power, 2017-04-21 14:41:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 15:00:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492785693435700,
"parent_rev": "d7eb90bb8049854a8c77604a6fc7c9e4f3d688bc", "commit_rev":
"419dd2a3447f1d39c092f4259d87906c192ed0da"}

[commit-bot: I haz the power, 2017-04-21 15:01:10]

Description was changed from

==========
Fix unsafe destruction order of InputDeviceFactoryEvdev

This was never destroyed prior to 60a7c584a9be ("mash: Don't synthesize
extra key press events in the window server").

Now it's destroyed in a couple places, so try to make this safe.
Particularly, destroy devices prior to shared state such as the gestures
properties object, and make devices stop DCHECKing that they are
destroyed gently (i.e., by getting disabled and stopped from the hotplug
handler). Shutdown destruction is abrupt.

This should fix a couple issues people are seeing since we started
calling the destructor (at least the input related ones).

BUG=711431, 713624, 713968
TEST=just compile
==========

to

==========
Fix unsafe destruction order of InputDeviceFactoryEvdev

This was never destroyed prior to 60a7c584a9be ("mash: Don't synthesize
extra key press events in the window server").

Now it's destroyed in a couple places, so try to make this safe.
Particularly, destroy devices prior to shared state such as the gestures
properties object, and make devices stop DCHECKing that they are
destroyed gently (i.e., by getting disabled and stopped from the hotplug
handler). Shutdown destruction is abrupt.

This should fix a couple issues people are seeing since we started
calling the destructor (at least the input related ones).

BUG=711431, 713624, 713968
TEST=just compile

Review-Url: https://codereview.chromium.org/2828843002
Cr-Commit-Position: refs/heads/master@{#466336}
Committed:
https://chromium.googlesource.com/chromium/src/+/419dd2a3447f1d39c092f4259d87...
==========

[commit-bot: I haz the power, 2017-04-21 15:01:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/419dd2a3447f1d39c092f4259d87...