Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: tools/metrics/actions/extract_actions.py

Issue 283313002: Ensure that any IPC sent from a child process that couldn't be deserialized causes that p… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: sync Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/metrics/actions/extract_actions.py
===================================================================
--- tools/metrics/actions/extract_actions.py (revision 270662)
+++ tools/metrics/actions/extract_actions.py (working copy)
@@ -67,6 +67,7 @@
'ppb_pdf_impl.cc', # see AddClosedSourceActions()
'pepper_pdf_host.cc', # see AddClosedSourceActions()
'key_systems_support_uma.cc', # See AddKeySystemSupportActions()
+ 'browser_child_process_host_impl.cc', # See AddBadMessageActions()
)
# Language codes used in Chrome. The list should be updated when a new
@@ -602,7 +603,24 @@
actions.add('AutomaticSettingsReset_WebUIBanner_ManuallyClosed')
actions.add('AutomaticSettingsReset_WebUIBanner_LearnMoreClicked')
+def AddBadMessageActions(actions):
+ """Add actions that are used when terminating a child process that sent an IPC
+ which couldn't be deserialized.
+ Arguments
+ actions: set of actions to add to.
+ """
+ actions.add('BadMessageTerminate_Plug-in')
+ actions.add('BadMessageTerminate_WebWorker')
+ actions.add('BadMessageTerminate_Utility')
+ actions.add('BadMessageTerminate_Zygote')
+ actions.add('BadMessageTerminate_Sandboxhelper')
+ actions.add('BadMessageTerminate_GPU')
+ actions.add('BadMessageTerminate_PepperPlugin')
+ actions.add('BadMessageTerminate_PepperPluginBroker')
+ actions.add('BadMessageTerminate_NativeClientmodule')
+ actions.add('BadMessageTerminate_NativeClientbroker')
+
class Error(Exception):
pass
@@ -808,6 +826,7 @@
AddExtensionActions(actions)
AddHistoryPageActions(actions)
AddKeySystemSupportActions(actions)
+ AddBadMessageActions(actions)
pretty = PrettyPrint(actions, actions_dict, comment_nodes)
if original_xml == pretty:

Powered by Google App Engine
This is Rietveld 408576698