Ensure that any IPC sent from a child process that couldn't be deserialized causes that p…

ipc/ipc_message_macros.h

Index: ipc/ipc_message_macros.h
===================================================================
--- ipc/ipc_message_macros.h	(revision 270662)
+++ ipc/ipc_message_macros.h	(working copy)
@@ -933,6 +933,8 @@
         TRACK_RUN_IN_IPC_HANDLER(member_func);                                 \
         msg_is_ok__ = msg_class::Dispatch(&ipc_message__, obj, this,           \
                                           param__, &member_func);              \
+        if (!msg_is_ok__)                                                      \
+          const_cast<IPC::Message&>(ipc_message__).set_dispatch_error();       \

[Tom Sepez, 2014/05/15 19:57:42]

What if we wanted to avoid the const cast by making the all the other places
non-const (since it's more accurate with this change). Kinda like pulling the
thread on a sweater ... ?

[jam, 2014/05/15 21:19:34]

actually, i can simplify this more now by making dispatch_error_ mutable. before
i was using the header field but that failed for other reasons. const_cast
removed now.

       }                                                                        \
       break;
 
@@ -944,6 +946,8 @@
         TRACK_RUN_IN_IPC_HANDLER(member_func);                                 \
         msg_is_ok__ = msg_class::DispatchDelayReply(&ipc_message__, obj,       \
                                                   param__, &member_func);      \
+        if (!msg_is_ok__)                                                      \
+          const_cast<IPC::Message&>(ipc_message__).set_dispatch_error();       \
       }                                                                        \
       break;