Ensure that any IPC sent from a child process that couldn't be deserialized causes that p…

tools/metrics/actions/extract_actions.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Extract UserMetrics "actions" strings from the Chrome source.
 
 This program generates the list of known actions we expect to see in the
 user behavior logs.  It walks the Chrome source, looking for calls to
@@ skipping 49 matching lines @@
   'external_metrics.cc',  # see AddChromeOSActions()
   'core_options_handler.cc',  # see AddWebUIActions()
   'browser_render_process_host.cc',  # see AddRendererActions()
   'render_thread_impl.cc',  # impl of RenderThread::RecordComputedAction()
   'render_process_host_impl.cc',  # browser side impl for
                                   # RenderThread::RecordComputedAction()
   'mock_render_thread.cc',  # mock of RenderThread::RecordComputedAction()
   'ppb_pdf_impl.cc',  # see AddClosedSourceActions()
   'pepper_pdf_host.cc',  # see AddClosedSourceActions()
   'key_systems_support_uma.cc',  # See AddKeySystemSupportActions()
+  'browser_child_process_host_impl.cc',  # See AddBadMessageActions()
 )
 
 # Language codes used in Chrome. The list should be updated when a new
 # language is added to app/l10n_util.cc, as follows:
 #
 # % (cat app/l10n_util.cc | \
 #    perl -n0e 'print $1 if /kAcceptLanguageList.*?\{(.*?)\}/s' | \
 #    perl -nle 'print $1, if /"(.*)"/'; echo 'es-419') | \
 #   sort | perl -pe "s/(.*)\n/'\$1', /" | \
 #   fold -w75 -s | perl -pe 's/^/  /;s/ $//'; echo
@@ skipping 515 matching lines @@
   actions.add('AutomaticReset_WebUIBanner_BannerShown')
   actions.add('AutomaticReset_WebUIBanner_ManuallyClosed')
   actions.add('AutomaticReset_WebUIBanner_ResetClicked')
 
   # These actions relate to the the automatic settings reset banner shown as
   # a result of settings hardening.
   actions.add('AutomaticSettingsReset_WebUIBanner_BannerShown')
   actions.add('AutomaticSettingsReset_WebUIBanner_ManuallyClosed')
   actions.add('AutomaticSettingsReset_WebUIBanner_LearnMoreClicked')
 
+def AddBadMessageActions(actions):
+  """Add actions that are used when terminating a child process that sent an IPC
+  which couldn't be deserialized.
+
+  Arguments
+    actions: set of actions to add to.
+  """
+  actions.add('BadMessageTerminate_Plug-in')
+  actions.add('BadMessageTerminate_WebWorker')
+  actions.add('BadMessageTerminate_Utility')
+  actions.add('BadMessageTerminate_Zygote')
+  actions.add('BadMessageTerminate_Sandboxhelper')
+  actions.add('BadMessageTerminate_GPU')
+  actions.add('BadMessageTerminate_PepperPlugin')
+  actions.add('BadMessageTerminate_PepperPluginBroker')
+  actions.add('BadMessageTerminate_NativeClientmodule')
+  actions.add('BadMessageTerminate_NativeClientbroker')
 
 class Error(Exception):
   pass
 
 
 def _ExtractText(parent_dom, tag_name):
   """Extract the text enclosed by |tag_name| under |parent_dom|
 
   Args:
     parent_dom: The parent Element under which text node is searched for.
@@ skipping 186 matching lines @@
   # print "Found {0} entries".format(len(actions))
 
   AddAndroidActions(actions)
   AddAutomaticResetBannerActions(actions)
   AddBookmarkManagerActions(actions)
   AddChromeOSActions(actions)
   AddClosedSourceActions(actions)
   AddExtensionActions(actions)
   AddHistoryPageActions(actions)
   AddKeySystemSupportActions(actions)
+  AddBadMessageActions(actions)
 
   pretty = PrettyPrint(actions, actions_dict, comment_nodes)
   if original_xml == pretty:
     print 'actions.xml is correctly pretty-printed.'
     sys.exit(0)
   if presubmit:
     logging.info('actions.xml is not formatted correctly; run '
                  'extract_actions.py to fix.')
     sys.exit(1)
 
   # Prompt user to consent on the change.
   if not diff_util.PromptUserToAcceptDiff(
       original_xml, pretty, 'Is the new version acceptable?'):
     logging.error('Aborting')
     sys.exit(1)
 
   print 'Creating backup file: actions.old.xml.'
   shutil.move(actions_xml_path, 'actions.old.xml')
 
   with open(actions_xml_path, 'wb') as f:
     f.write(pretty)
   print ('Updated %s. Don\'t forget to add it to your changelist' %
          actions_xml_path)
   return 0
 
 
 if '__main__' == __name__:
   sys.exit(main(sys.argv))