chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc - Issue 283303002: Fixes the crash when the transient parent is NULL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc

Issue 283303002: Fixes the crash when the transient parent is NULL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc

diff --git a/chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc b/chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc

index 6c98e80514b81ee178a60cec075b12b5e886c03f..971eecc633679eae293f341f88029a9e1dafad3a 100644

--- a/chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc

+++ b/chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc

@@ -241,7 +241,8 @@ void PrintDialogGtk2::ShowDialog(

dialog_ = gtk_print_unix_dialog_new(NULL, NULL);

libgtk2ui::SetGtkTransientForAura(dialog_, parent_view);

- parent_view->AddObserver(this);

+ if (parent_view)

+ parent_view->AddObserver(this);

g_signal_connect(dialog_, "delete-event",

G_CALLBACK(gtk_widget_hide_on_delete), NULL);

« no previous file with comments | « chrome/browser/ui/libgtk2ui/gtk2_util.cc ('k') | no next file » | no next file with comments »