chrome/browser/ui/libgtk2ui/gtk2_util.cc - Issue 283303002: Fixes the crash when the transient parent is NULL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/libgtk2ui/gtk2_util.cc

Issue 283303002: Fixes the crash when the transient parent is NULL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/libgtk2ui/gtk2_util.cc

diff --git a/chrome/browser/ui/libgtk2ui/gtk2_util.cc b/chrome/browser/ui/libgtk2ui/gtk2_util.cc

index a2c1e6c801a7e1ff6a15e13b446c17ab090d7aa9..48ead410e21a9d2faf893268f19a27fb1b5eb41c 100644

--- a/chrome/browser/ui/libgtk2ui/gtk2_util.cc

+++ b/chrome/browser/ui/libgtk2ui/gtk2_util.cc

@@ -103,9 +103,10 @@ int EventFlagsFromGdkState(guint state) {

return flags;

}

-// Set |dialog| as transient for |parent|, which will keep it on top and center

-// it above |parent|.

void SetGtkTransientForAura(GtkWidget* dialog, aura::Window* parent) {

+ if (!parent)

+ return;

gtk_widget_realize(dialog);

GdkWindow* gdk_window = gtk_widget_get_window(dialog);