Issue 2833014: Add a 1px white bezel under the dark line separating the tab strip and the to...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2833014: Add a 1px white bezel under the dark line separating the tab strip and the to... (Closed)

Created:
10 years, 6 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add a 1px white bezel under the dark line separating the tab strip and the toolbar. Tabs are now responsible for mimicing this line when drawing unselected. BUG=44574 TEST=none. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50137

Patch Set 1 #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -12 lines)			Patch
M	chrome/browser/cocoa/tab_strip_controller.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/tab_strip_view.mm	View	1 chunk	+10 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/tab_view.mm	View	2 chunks	+16 lines, -9 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

LGTM http://codereview.chromium.org/2833014/diff/1/4 File chrome/browser/cocoa/tab_view.mm (right): http://codereview.chromium.org/2833014/diff/1/4#newcode763 chrome/browser/cocoa/tab_view.mm:763: NSRect tempRect = rect; Call this something like ...

10 years, 6 months ago (2010-06-17 20:25:52 UTC) #2

pink (ping after 24hrs)

10 years, 6 months ago (2010-06-17 20:26:53 UTC) #3

done.

On Thu, Jun 17, 2010 at 4:25 PM,  <rohitrao@chromium.org> wrote:
> LGTM
>
>
> http://codereview.chromium.org/2833014/diff/1/4
> File chrome/browser/cocoa/tab_view.mm (right):
>
> http://codereview.chromium.org/2833014/diff/1/4#newcode763
> chrome/browser/cocoa/tab_view.mm:763: NSRect tempRect = rect;
> Call this something like fillRect instead of tempRect.
>
> http://codereview.chromium.org/2833014/show
>



-- 
Mike Pinkerton
Mac Weenie
pinkerton@google.com

Expand Messages | Collapse Messages