Add a 1px white bezel under the dark line separating the tab strip and the to...

chrome/browser/cocoa/tab_view.mm

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/cocoa/tab_view.h"
 
 #include "base/logging.h"
 #include "base/nsimage_cache_mac.h"
 #include "chrome/browser/browser_theme_provider.h"
 #import "chrome/browser/cocoa/tab_controller.h"
@@ skipping 591 matching lines @@
   // element that will represent this tab is the favicon.
   if ([controller_ phantom])
     return;
 
   NSGraphicsContext* context = [NSGraphicsContext currentContext];
   [context saveGraphicsState];
   rect = [self bounds];
   BOOL active = [[self window] isKeyWindow] || [[self window] isMainWindow];
   BOOL selected = [self state];
 
-  // Inset by 0.5 in order to draw on pixels rather than on borders (which would
-  // cause blurry pixels). Decrease height by 1 in order to move away from the
-  // edge for the dark shadow.
+  // Outset by 0.5 in order to draw on pixels rather than on borders (which
+  // would cause blurry pixels). Subtract 1px of height to compensate,
+  // otherwise clipping will occur.
   rect = NSInsetRect(rect, -0.5, -0.5);
-  rect.origin.y -= 1;
+  rect.size.height -= 1;
 
   NSPoint bottomLeft = NSMakePoint(NSMinX(rect), NSMinY(rect) + 2);
   NSPoint bottomRight = NSMakePoint(NSMaxX(rect), NSMinY(rect) + 2);
   NSPoint topRight =
       NSMakePoint(NSMaxX(rect) - kInsetMultiplier * NSHeight(rect),
                   NSMaxY(rect));
   NSPoint topLeft =
       NSMakePoint(NSMinX(rect)  + kInsetMultiplier * NSHeight(rect),
                   NSMaxY(rect));
 
@@ skipping 122 matching lines @@
   if (selected) {
     [[NSColor colorWithDeviceWhite:0.0 alpha:active ? 0.3 : 0.15] set];
   } else {
     [[NSColor colorWithDeviceWhite:0.0 alpha:active ? 0.2 : 0.15] set];
     [[NSBezierPath bezierPathWithRect:NSOffsetRect(rect, 0, 2.5)] addClip];
   }
   [path setLineWidth:1.0];
   [path stroke];
   [context restoreGraphicsState];
 
-  // Draw the bottom border.
+  // Mimic the tab strip's bottom border, which consists of a dark border
+  // and light highlight.
   if (!selected) {
     [path addClip];
-    NSRect borderRect, contentRect;
-    NSDivideRect(rect, &borderRect, &contentRect, 2.5, NSMinYEdge);
-    [[NSColor colorWithDeviceWhite:0.0 alpha:active ? 0.3 : 0.15] set];
-    NSRectFillUsingOperation(borderRect, NSCompositeSourceOver);
+    NSRect tempRect = rect;

[rohitrao (ping after 24h), 2010/06/17 20:25:52]

Call this something like fillRect instead of tempRect.

+    tempRect.origin.y = 1;
+    tempRect.size.height = 1;
+    [[NSColor colorWithDeviceWhite:0.0 alpha:active ? 0.2 : 0.15] set];
+    NSRectFillUsingOperation(tempRect, NSCompositeSourceOver);
+
+    tempRect.origin.y = 0;
+    [[NSColor colorWithCalibratedWhite:0.96 alpha:1.0] set];
+    NSRectFillUsingOperation(tempRect, NSCompositeSourceOver);
   }
+
   [context restoreGraphicsState];
 }
 
 - (void)viewDidMoveToWindow {
   [super viewDidMoveToWindow];
   if ([self window]) {
     [controller_ updateTitleColor];
   }
 }
 
@@ skipping 173 matching lines @@
   }
 
   if (nextUpdate < kNoUpdate)
     [self performSelector:_cmd withObject:nil afterDelay:nextUpdate];
 
   [self resetLastGlowUpdateTime];
   [self setNeedsDisplay:YES];
 }
 
 @end  // @implementation TabView(Private)