Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1936)

Unified Diff: chrome/browser/cocoa/tab_strip_view.mm

Issue 2833014: Add a 1px white bezel under the dark line separating the tab strip and the to... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/tab_strip_view.mm
===================================================================
--- chrome/browser/cocoa/tab_strip_view.mm (revision 49817)
+++ chrome/browser/cocoa/tab_strip_view.mm (working copy)
@@ -31,10 +31,18 @@
- (void)drawRect:(NSRect)rect {
NSRect boundsRect = [self bounds];
NSRect borderRect, contentRect;
- NSDivideRect(boundsRect, &borderRect, &contentRect, 1, NSMinYEdge);
+
+ // Draw bottom border (a dark border and light highlight). Each tab is
+ // responsible for mimicing this bottom border, unless it's the selected
+ // tab.
+ borderRect = boundsRect;
+ borderRect.origin.y = 1;
+ borderRect.size.height = 1;
[[NSColor colorWithCalibratedWhite:0.0 alpha:0.2] set];
-
NSRectFillUsingOperation(borderRect, NSCompositeSourceOver);
+ NSDivideRect(boundsRect, &borderRect, &contentRect, 1, NSMinYEdge);
+ [[NSColor colorWithCalibratedWhite:0.96 alpha:1.0] set];
+ NSRectFillUsingOperation(borderRect, NSCompositeSourceOver);
// Draw drop-indicator arrow (if appropriate).
// TODO(viettrungluu): this is all a stop-gap measure.

Powered by Google App Engine
This is Rietveld 408576698