Chromium Code Reviews Chromium Code Reviews
Issue
2832963002:
Reland of Add --headless flag to Windows (Closed)
DescriptionReland of Add --headless flag to Windows (patchset #1 id:1 of https://codereview.chromium.org/2835603002/ )
Reason for revert:
Re-land patch set, looks like it could've been a transient issue with Mac waterfall build, patching in updated upstream and investigating
Original issue's description:
> Revert of Add --headless flag to Windows (patchset #28 id:540001 of https://codereview.chromium.org/2762593002/ )
>
> Reason for revert:
>
> Findit(https://goo.gl/kROfz5) identified CL at revision 466176 as the
> culprit for failures in the build cycles as shown on:
> https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2UzYzc0NWQ0YjM3YTY1OWFmYWEwMzU4YzdkZTdiOWJjODgxZGVjYjUM
>
> Original issue's description:
> > Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=705916
> >
> > Add --headless flag to Windows:
> >
> > Fix browser_tests not compiling properly on windows
> > Fix headless/BUILD.gn by:
> > - Changing headless_lib to a headless component, following steps in https://chromium.googlesource.com/chromium/src/+/master/docs/component_build.md and fixing the build for linux, since it now compiles as a shared_library when component build is true.
> > - Adding neccesary HEADLESS_EXPORT (submitted in https://codereview.chromium.org/2775693003/)
> > - Disabling breakpad in windows (will fix in a separate CL)
> >
> >
> > BUG=686608
> >
> > Review-Url: https://codereview.chromium.org/2762593002
> > Cr-Commit-Position: refs/heads/master@{#466176}
> > Committed: https://chromium.googlesource.com/chromium/src/+/e3c745d4b37a659afaa0358c7de7b9bc881decb5
>
> TBR=alexclarke@chromium.org,sky@chromium.org,skyostil@chromium.org,wfh@chromium.org,jzfeng@chromium.org,nick@chromium.org,dvallet@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=686608
>
> Review-Url: https://codereview.chromium.org/2835603002
> Cr-Commit-Position: refs/heads/master@{#466189}
> Committed: https://chromium.googlesource.com/chromium/src/+/87a65c2fbb5db04ce025fadbfdfc7183003f6831
TBR=nick@chromium.org,tdanderson@google.com,jzfeng@chromium.org,fhorschig@google.com,sky@chromium.org,keishi@google.com,xlai@google.com,alexclarke@chromium.org,skyostil@chromium.org,wfh@chromium.org,tdanderson@chromium.org,findit-for-me@appspot.gserviceaccount.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=686608
Review-Url: https://codereview.chromium.org/2832963002
Cr-Commit-Position: refs/heads/master@{#466206}
Committed: https://chromium.googlesource.com/chromium/src/+/e0800c0393765b299e3fcd81f2d97b8bbe997a2f
Patch Set 1 #
Messages
Total messages: 20 (10 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
