Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 2835603002: Revert of Add --headless flag to Windows (Closed)

Created:
3 years, 8 months ago by findit-for-me
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add --headless flag to Windows (patchset #28 id:540001 of https://codereview.chromium.org/2762593002/ ) Reason for revert: Findit(https://goo.gl/kROfz5) identified CL at revision 466176 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2UzYzc0NWQ0YjM3YTY1OWFmYWEwMzU4YzdkZTdiOWJjODgxZGVjYjUM Original issue's description: > Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=705916 > > Add --headless flag to Windows: > > Fix browser_tests not compiling properly on windows > Fix headless/BUILD.gn by: > - Changing headless_lib to a headless component, following steps in https://chromium.googlesource.com/chromium/src/+/master/docs/component_build.md and fixing the build for linux, since it now compiles as a shared_library when component build is true. > - Adding neccesary HEADLESS_EXPORT (submitted in https://codereview.chromium.org/2775693003/) > - Disabling breakpad in windows (will fix in a separate CL) > > > BUG=686608 > > Review-Url: https://codereview.chromium.org/2762593002 > Cr-Commit-Position: refs/heads/master@{#466176} > Committed: https://chromium.googlesource.com/chromium/src/+/e3c745d4b37a659afaa0358c7de7b9bc881decb5 TBR=alexclarke@chromium.org,sky@chromium.org,skyostil@chromium.org,wfh@chromium.org,jzfeng@chromium.org,nick@chromium.org,dvallet@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=686608 Review-Url: https://codereview.chromium.org/2835603002 Cr-Commit-Position: refs/heads/master@{#466189} Committed: https://chromium.googlesource.com/chromium/src/+/87a65c2fbb5db04ce025fadbfdfc7183003f6831

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -292 lines) Patch
M chrome/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/app/chrome_main.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M headless/BUILD.gn View 10 chunks +40 lines, -130 lines 0 comments Download
M headless/DEPS View 2 chunks +0 lines, -2 lines 0 comments Download
M headless/app/headless_example.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M headless/app/headless_shell.h View 1 chunk +1 line, -1 line 0 comments Download
M headless/app/headless_shell.cc View 6 chunks +4 lines, -26 lines 0 comments Download
M headless/app/headless_shell_main.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M headless/app/headless_shell_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M headless/app/headless_shell_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M headless/lib/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M headless/lib/browser/headless_browser_impl.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M headless/lib/headless_browser_browsertest.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M headless/lib/headless_content_main_delegate.h View 3 chunks +4 lines, -4 lines 0 comments Download
M headless/lib/headless_content_main_delegate.cc View 5 chunks +3 lines, -14 lines 0 comments Download
M headless/public/headless_browser.h View 7 chunks +4 lines, -22 lines 0 comments Download
M headless/public/headless_browser.cc View 3 chunks +0 lines, -20 lines 0 comments Download
M headless/public/headless_shell.h View 1 chunk +2 lines, -16 lines 0 comments Download
M headless/public/util/deterministic_http_protocol_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M headless/public/util/generic_url_request_job.h View 4 chunks +3 lines, -4 lines 0 comments Download
M headless/public/util/testing/generic_url_request_mocks.cc View 1 chunk +0 lines, -1 line 0 comments Download
M headless/test/headless_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
findit-for-me
Created Revert of Add --headless flag to Windows
3 years, 8 months ago (2017-04-20 23:22:38 UTC) #1
findit-for-me
Sheriffs: Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct. If ...
3 years, 8 months ago (2017-04-20 23:22:40 UTC) #3
tdanderson
lgtm
3 years, 8 months ago (2017-04-20 23:31:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835603002/1
3 years, 8 months ago (2017-04-20 23:31:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/87a65c2fbb5db04ce025fadbfdfc7183003f6831
3 years, 8 months ago (2017-04-20 23:33:05 UTC) #10
dvallet
3 years, 8 months ago (2017-04-21 00:03:43 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2832963002/ by dvallet@chromium.org.

The reason for reverting is: Re-land patch set, looks like it could've been a
transient issue with Mac waterfall build, patching in updated upstream and
investigating.

Powered by Google App Engine
This is Rietveld 408576698