Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2832953002: [Merge to M59] Fix MD display settings when the display supports a single resolution (Closed)

Created:
3 years, 8 months ago by afakhry
Modified:
3 years, 8 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Merge to M59] Fix MD display settings when the display supports a single resolution Use this.$.slider.value instead of this.$slider.immediateValue when this.$.slider.immediateValue is invalid. TBR=stevenjb@chromium.org BUG=712842 TEST=manually by connected an MIMO external USB display. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2829663004 Cr-Commit-Position: refs/heads/master@{#465807} (cherry picked from commit 77ac96ae13745efb0300a75232dca1251cd5ada2) Review-Url: https://codereview.chromium.org/2832953002 . Cr-Commit-Position: refs/branch-heads/3071@{#106} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/ee13d6d2a7d3ca2b27c897a1567d915f2cf900f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/resources/settings/controls/settings_slider.js View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
afakhry
3 years, 8 months ago (2017-04-21 00:05:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ee13d6d2a7d3ca2b27c897a1567d915f2cf900f6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698