Fix MD display settings when the display supports a single resolution

Fix MD display settings when the display supports a single resolution

Use this.$.slider.value instead of this.$slider.immediateValue when
this.$.slider.immediateValue is invalid.

BUG=712842
TEST=manually by connected an MIMO external USB display.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2829663004
Cr-Commit-Position: refs/heads/master@{#465807}
Committed: https://chromium.googlesource.com/chromium/src/+/77ac96ae13745efb0300a75232dca1251cd5ada2

[afakhry, 2017-04-19 19:18:52]

Description was changed from

==========
Fix MD display settings when the display supports a single resolution

Use this.$.slider.value instead of this.$slider.immediateValue when
this.$.slider.immediateValue is invalid.

BUG=712842
TEST=manually by connected an MIMO external USB display.
==========

to

==========
Fix MD display settings when the display supports a single resolution

Use this.$.slider.value instead of this.$slider.immediateValue when
this.$.slider.immediateValue is invalid.

BUG=712842
TEST=manually by connected an MIMO external USB display.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[afakhry, 2017-04-19 19:19:36]

afakhry@chromium.org changed reviewers:
+ stevenjb@chromium.org

[afakhry, 2017-04-19 19:19:37]

Steven, as agreed, please take a look. Thanks!

[stevenjb, 2017-04-19 19:24:16]

Thanks!

https://codereview.chromium.org/2829663004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/controls/settings_slider.js (right):

https://codereview.chromium.org/2829663004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/controls/settings_slider.js:54:
(this.$.slider.immediateValue && this.$.slider.immediateValue != NaN)
immediateValue == 0 should be valid, check explicitly for === undefined instead.

[afakhry, 2017-04-19 20:08:24]

https://codereview.chromium.org/2829663004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/controls/settings_slider.js (right):

https://codereview.chromium.org/2829663004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/controls/settings_slider.js:54:
(this.$.slider.immediateValue && this.$.slider.immediateValue != NaN)
On 2017/04/19 19:24:16, stevenjb wrote:
> immediateValue == 0 should be valid, check explicitly for === undefined
instead.

Done. 
Also, I asked xiyuan, and he told me that the right way to check for NaN is to
call isNaN():
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Obje...

So I modified that too. Please take a look.

[stevenjb, 2017-04-19 20:31:28]

lgtm w/ or without suggested change.

https://codereview.chromium.org/2829663004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/controls/settings_slider.js (right):

https://codereview.chromium.org/2829663004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/controls/settings_slider.js:54:
isNaN(this.$.slider.immediateValue))
Ah, yes, this is better, and it looks like isNan(undefined) returns true, so we
could remove the first test.

[afakhry, 2017-04-19 22:22:41]

https://codereview.chromium.org/2829663004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/controls/settings_slider.js (right):

https://codereview.chromium.org/2829663004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/controls/settings_slider.js:54:
isNaN(this.$.slider.immediateValue))
On 2017/04/19 20:31:28, stevenjb wrote:
> Ah, yes, this is better, and it looks like isNan(undefined) returns true, so
we
> could remove the first test.

Oh, awesome! This is actually better. Done!

[afakhry, 2017-04-19 22:22:46]

The CQ bit was checked by afakhry@chromium.org

[afakhry, 2017-04-19 22:22:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2829663004/#ps40001
(title: "isNaN() only")

[commit-bot: I haz the power, 2017-04-19 22:23:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 23:33:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492640566723460,
"parent_rev": "384441de29b19bbf6aaa7e1d4f7f267827f10595", "commit_rev":
"77ac96ae13745efb0300a75232dca1251cd5ada2"}

[commit-bot: I haz the power, 2017-04-19 23:33:27]

Description was changed from

==========
Fix MD display settings when the display supports a single resolution

Use this.$.slider.value instead of this.$slider.immediateValue when
this.$.slider.immediateValue is invalid.

BUG=712842
TEST=manually by connected an MIMO external USB display.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix MD display settings when the display supports a single resolution

Use this.$.slider.value instead of this.$slider.immediateValue when
this.$.slider.immediateValue is invalid.

BUG=712842
TEST=manually by connected an MIMO external USB display.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2829663004
Cr-Commit-Position: refs/heads/master@{#465807}
Committed:
https://chromium.googlesource.com/chromium/src/+/77ac96ae13745efb0300a75232dc...
==========

[commit-bot: I haz the power, 2017-04-19 23:33:29]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/77ac96ae13745efb0300a75232dc...