Remove unneeded Convert* methods and move many from FrameViewBase to FrameView

Remove unneeded Convert* methods and move many from FrameViewBase to FrameView.

I am cleaning up the Convert methods and moving them out of FrameViewBase
in preparation for removing Scrollbar from inheriting from FrameViewBase.
With this change, Scrollbar no longer has any calls to FrameViewBase methods.

There were Convert methods in scrollbar classes that are never called.
* Scrollbar
 - ConvertFromContainingFrameViewBase(IntRect)
 - ConvertToContainingFrameViewBase(IntPoint)
* ScrollableArea and PaintLayerScrollableArea
 - ConvertFromContainingFrameViewBaseToScrollbar(IntPoint)

BUG=637460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2832883003
Cr-Commit-Position: refs/heads/master@{#466440}
Committed: https://chromium.googlesource.com/chromium/src/+/5a589220480eef0ce8436e3bdd00c796d914a596

[joelhockey, 2017-04-20 23:44:28]

Description was changed from

==========
[TEST] remove unneeded coord convert methods.

BUG=637460
==========

to

==========
[TEST] remove unneeded coord convert methods.

BUG=637460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[joelhockey, 2017-04-20 23:44:40]

The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 23:44:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 01:00:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 01:00:28]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[joelhockey, 2017-04-21 01:58:12]

The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 01:58:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 02:42:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 02:42:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[joelhockey, 2017-04-21 06:28:07]

The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 06:28:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joelhockey, 2017-04-21 06:37:39]

Description was changed from

==========
[TEST] remove unneeded coord convert methods.

BUG=637460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove unneeded Convert* methods and move many from FrameViewBase to FrameView.

I am cleaning up the Convert methods and moving them out of FrameViewBase
in preparation for removing Scrollbar from inheriting from FrameViewBase.
With this change, Scrollbar no longer has any calls to FrameViewBase methods.



BUG=637460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[joelhockey, 2017-04-21 06:37:39]

joelhockey@chromium.org changed reviewers:
+ dcheng@chromium.org, haraken@chromium.org, slangley@chromium.org

[joelhockey, 2017-04-21 06:45:47]

Description was changed from

==========
Remove unneeded Convert* methods and move many from FrameViewBase to FrameView.

I am cleaning up the Convert methods and moving them out of FrameViewBase
in preparation for removing Scrollbar from inheriting from FrameViewBase.
With this change, Scrollbar no longer has any calls to FrameViewBase methods.



BUG=637460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove unneeded Convert* methods and move many from FrameViewBase to FrameView.

I am cleaning up the Convert methods and moving them out of FrameViewBase
in preparation for removing Scrollbar from inheriting from FrameViewBase.
With this change, Scrollbar no longer has any calls to FrameViewBase methods.

There were many Convert[To|From]* methods in scrollbar classes that
are never called.
* Scrollbar::Convert[To|From]ContainingFrameViewBase
* ScrollableArea::Convert...
 - only method which is used is
   ConvertFromContainingFrameViewBaseToScrollbar(IntPoint)
* PaintLayerScrollableArea::Convert...
 - only method which is used is 
   ConvertFromContainingFrameViewBaseToScrollbar(IntPoint)

BUG=637460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[joelhockey, 2017-04-21 06:47:25]

The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 06:47:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-04-21 07:10:39]

dcheng@chromium.org changed reviewers:
+ szager@chromium.org

[dcheng, 2017-04-21 07:10:39]

I didn't review this CL completely, but it looks like good cleanup. That being
said, someone from layout should look at this. +szager

https://codereview.chromium.org/2832883003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/FrameView.h (right):

https://codereview.chromium.org/2832883003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.h:949: // Override FrameViewBase
methods to do point conversion via layoutObjects, in
I think this comment needs to be updated.

[commit-bot: I haz the power, 2017-04-21 07:11:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 07:11:29]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[joelhockey, 2017-04-21 07:31:56]

The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 07:32:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joelhockey, 2017-04-21 07:34:21]

On 2017/04/21 at 07:10:39, dcheng wrote:
> I didn't review this CL completely, but it looks like good cleanup. That being
said, someone from layout should look at this. +szager

I've just noticed that there was one method in Scrollbar that I deleted which is
used by ScrollAnimatorMac.mm.  That should be fixed now.

[joelhockey, 2017-04-21 07:36:21]

https://codereview.chromium.org/2832883003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/FrameView.h (right):

https://codereview.chromium.org/2832883003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/FrameView.h:949: // Override FrameViewBase
methods to do point conversion via layoutObjects, in
On 2017/04/21 at 07:10:39, dcheng (OOO through May 2) wrote:
> I think this comment needs to be updated.

Done

[joelhockey, 2017-04-21 07:36:52]

The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 07:37:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joelhockey, 2017-04-21 07:46:57]

Description was changed from

==========
Remove unneeded Convert* methods and move many from FrameViewBase to FrameView.

I am cleaning up the Convert methods and moving them out of FrameViewBase
in preparation for removing Scrollbar from inheriting from FrameViewBase.
With this change, Scrollbar no longer has any calls to FrameViewBase methods.

There were many Convert[To|From]* methods in scrollbar classes that
are never called.
* Scrollbar::Convert[To|From]ContainingFrameViewBase
* ScrollableArea::Convert...
 - only method which is used is
   ConvertFromContainingFrameViewBaseToScrollbar(IntPoint)
* PaintLayerScrollableArea::Convert...
 - only method which is used is 
   ConvertFromContainingFrameViewBaseToScrollbar(IntPoint)

BUG=637460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove unneeded Convert* methods and move many from FrameViewBase to FrameView.

I am cleaning up the Convert methods and moving them out of FrameViewBase
in preparation for removing Scrollbar from inheriting from FrameViewBase.
With this change, Scrollbar no longer has any calls to FrameViewBase methods.

There were Convert methods in scrollbar classes that are never called.
* Scrollbar
 - ConvertFromContainingFrameViewBase(IntRect)
 - ConvertToContainingFrameViewBase(IntPoint)
* ScrollableArea and PaintLayerScrollableArea
 - ConvertFromContainingFrameViewBaseToScrollbar(IntPoint)

BUG=637460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[haraken, 2017-04-21 08:34:10]

LGTM on my side, though I want to have szager@ take a close look at this.

[commit-bot: I haz the power, 2017-04-21 09:48:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 09:48:06]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[joelhockey, 2017-04-21 11:19:16]

The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 11:19:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joelhockey, 2017-04-21 12:58:00]

The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 12:58:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 14:30:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 14:30:21]

Dry run: This issue passed the CQ dry run.

[szager1, 2017-04-21 14:59:29]

lgtm

[joelhockey, 2017-04-21 20:41:26]

The CQ bit was checked by joelhockey@chromium.org

[joelhockey, 2017-04-21 20:41:26]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2832883003/#ps140001
(title: "fix ScrollableArea::ConvertFromScrollbarToContainingFrameViewBase and
remove dchecks")

[commit-bot: I haz the power, 2017-04-21 20:41:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 20:46:31]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1492807286066500,
"parent_rev": "35538b8b90321ddbae3998cc3c1a53f392341ef4", "commit_rev":
"5a589220480eef0ce8436e3bdd00c796d914a596"}

[commit-bot: I haz the power, 2017-04-21 20:46:41]

Description was changed from

==========
Remove unneeded Convert* methods and move many from FrameViewBase to FrameView.

I am cleaning up the Convert methods and moving them out of FrameViewBase
in preparation for removing Scrollbar from inheriting from FrameViewBase.
With this change, Scrollbar no longer has any calls to FrameViewBase methods.

There were Convert methods in scrollbar classes that are never called.
* Scrollbar
 - ConvertFromContainingFrameViewBase(IntRect)
 - ConvertToContainingFrameViewBase(IntPoint)
* ScrollableArea and PaintLayerScrollableArea
 - ConvertFromContainingFrameViewBaseToScrollbar(IntPoint)

BUG=637460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Remove unneeded Convert* methods and move many from FrameViewBase to FrameView.

I am cleaning up the Convert methods and moving them out of FrameViewBase
in preparation for removing Scrollbar from inheriting from FrameViewBase.
With this change, Scrollbar no longer has any calls to FrameViewBase methods.

There were Convert methods in scrollbar classes that are never called.
* Scrollbar
 - ConvertFromContainingFrameViewBase(IntRect)
 - ConvertToContainingFrameViewBase(IntPoint)
* ScrollableArea and PaintLayerScrollableArea
 - ConvertFromContainingFrameViewBaseToScrollbar(IntPoint)

BUG=637460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2832883003
Cr-Commit-Position: refs/heads/master@{#466440}
Committed:
https://chromium.googlesource.com/chromium/src/+/5a589220480eef0ce8436e3bdd00...
==========

[commit-bot: I haz the power, 2017-04-21 20:46:43]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/5a589220480eef0ce8436e3bdd00...