third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h - Issue 2832883003: Remove unneeded Convert* methods and move many from FrameViewBase to FrameView

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

Issue 2832883003: Remove unneeded Convert* methods and move many from FrameViewBase to FrameView (Closed)

Patch Set: fix ScrollableArea::ConvertFromScrollbarToContainingFrameViewBase and remove dchecks Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/RemoteFrameView.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.	2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.

3 *	3 *

4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.	4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.

5 *	5 *

6 * Other contributors:	6 * Other contributors:

7 * Robert O'Callahan <roc+@cs.cmu.edu>	7 * Robert O'Callahan <roc+@cs.cmu.edu>

8 * David Baron <dbaron@fas.harvard.edu>	8 * David Baron <dbaron@fas.harvard.edu>

9 * Christian Biesinger <cbiesinger@web.de>	9 * Christian Biesinger <cbiesinger@web.de>

10 * Randall Jesup <rjesup@wgate.com>	10 * Randall Jesup <rjesup@wgate.com>

(...skipping 245 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
256	256

257 bool UsesCompositedScrolling() const override;	257 bool UsesCompositedScrolling() const override;

258 bool ShouldScrollOnMainThread() const override;	258 bool ShouldScrollOnMainThread() const override;

259 bool ShouldUseIntegerScrollOffset() const override;	259 bool ShouldUseIntegerScrollOffset() const override;

260 bool IsActive() const override;	260 bool IsActive() const override;

261 bool IsScrollCornerVisible() const override;	261 bool IsScrollCornerVisible() const override;

262 IntRect ScrollCornerRect() const override;	262 IntRect ScrollCornerRect() const override;

263 IntRect ConvertFromScrollbarToContainingFrameViewBase(	263 IntRect ConvertFromScrollbarToContainingFrameViewBase(

264 const Scrollbar&,	264 const Scrollbar&,

265 const IntRect&) const override;	265 const IntRect&) const override;

266 IntRect ConvertFromContainingFrameViewBaseToScrollbar(

267 const Scrollbar&,

268 const IntRect&) const override;

269 IntPoint ConvertFromScrollbarToContainingFrameViewBase(	266 IntPoint ConvertFromScrollbarToContainingFrameViewBase(

270 const Scrollbar&,	267 const Scrollbar&,

271 const IntPoint&) const override;	268 const IntPoint&) const override;

272 IntPoint ConvertFromContainingFrameViewBaseToScrollbar(	269 IntPoint ConvertFromContainingFrameViewBaseToScrollbar(

273 const Scrollbar&,	270 const Scrollbar&,

274 const IntPoint&) const override;	271 const IntPoint&) const override;

275 int ScrollSize(ScrollbarOrientation) const override;	272 int ScrollSize(ScrollbarOrientation) const override;

276 IntSize ScrollOffsetInt() const override;	273 IntSize ScrollOffsetInt() const override;

277 ScrollOffset GetScrollOffset() const override;	274 ScrollOffset GetScrollOffset() const override;

278 IntSize MinimumScrollOffsetInt() const override;	275 IntSize MinimumScrollOffsetInt() const override;

(...skipping 325 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
604	601

605 DEFINE_TYPE_CASTS(PaintLayerScrollableArea,	602 DEFINE_TYPE_CASTS(PaintLayerScrollableArea,

606 ScrollableArea,	603 ScrollableArea,

607 scrollableArea,	604 scrollableArea,

608 scrollableArea->IsPaintLayerScrollableArea(),	605 scrollableArea->IsPaintLayerScrollableArea(),

609 scrollableArea.IsPaintLayerScrollableArea());	606 scrollableArea.IsPaintLayerScrollableArea());

610	607

611 } // namespace blink	608 } // namespace blink

612	609

613 #endif // LayerScrollableArea_h	610 #endif // LayerScrollableArea_h

OLD	NEW