[test/inspector] remove any usage of v8::Extension

[test/inspector] remove any usage of v8::Extension

.. replace all of them with prepared global object template.

+ bonus: wrap inspector related methods with inspector namespace.

BUG=none
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2832723004
Cr-Commit-Position: refs/heads/master@{#44785}
Committed: https://chromium.googlesource.com/v8/v8/+/ec36c513a3b44c8afc3e2fb471c47395546a3faa

[kozy, 2017-04-20 22:32:32]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 22:32:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2017-04-20 22:33:06]

Dmitry, please take a look.

[commit-bot: I haz the power, 2017-04-20 22:34:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 22:34:04]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/26303)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/26402)

[kozy, 2017-04-20 22:39:30]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 22:39:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 22:41:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 22:41:10]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/26304)

[dgozman, 2017-04-20 23:16:38]

https://codereview.chromium.org/2832723004/diff/20001/test/inspector/debugger...
File test/inspector/debugger/framework-break-expected.txt (right):

https://codereview.chromium.org/2832723004/diff/20001/test/inspector/debugger...
test/inspector/debugger/framework-break-expected.txt:46: syncDOMBreakpoint
(framework.js:33:12)
why the change?

https://codereview.chromium.org/2832723004/diff/20001/test/inspector/inspecto...
File test/inspector/inspector-test.cc (right):

https://codereview.chromium.org/2832723004/diff/20001/test/inspector/inspecto...
test/inspector/inspector-test.cc:54: class SetTimeoutTask : public AsyncTask {
Why move the code? Put it back for small delta.

https://codereview.chromium.org/2832723004/diff/20001/test/inspector/task-run...
File test/inspector/task-runner.h (right):

https://codereview.chromium.org/2832723004/diff/20001/test/inspector/task-run...
test/inspector/task-runner.h:45: typedef
std::vector<std::unique_ptr<SetupGlobalTask>> SetupGlobalTasks;
using

[kozy, 2017-04-20 23:38:19]

all done, please take another look.

https://codereview.chromium.org/2832723004/diff/20001/test/inspector/debugger...
File test/inspector/debugger/framework-break-expected.txt (right):

https://codereview.chromium.org/2832723004/diff/20001/test/inspector/debugger...
test/inspector/debugger/framework-break-expected.txt:46: syncDOMBreakpoint
(framework.js:33:12)
On 2017/04/20 23:16:38, dgozman wrote:
> why the change?

"inspector.".length === 10

https://codereview.chromium.org/2832723004/diff/20001/test/inspector/inspecto...
File test/inspector/inspector-test.cc (right):

https://codereview.chromium.org/2832723004/diff/20001/test/inspector/inspecto...
test/inspector/inspector-test.cc:54: class SetTimeoutTask : public AsyncTask {
On 2017/04/20 23:16:38, dgozman wrote:
> Why move the code? Put it back for small delta.

Done.

https://codereview.chromium.org/2832723004/diff/20001/test/inspector/task-run...
File test/inspector/task-runner.h (right):

https://codereview.chromium.org/2832723004/diff/20001/test/inspector/task-run...
test/inspector/task-runner.h:45: typedef
std::vector<std::unique_ptr<SetupGlobalTask>> SetupGlobalTasks;
On 2017/04/20 23:16:38, dgozman wrote:
> using

Done.

[kozy, 2017-04-20 23:38:38]

Description was changed from

==========
[test/inspector] remove any usage of v8::Extension

.. replace all of them with prepared global object template.

+ bonus: wrap inspector related methods in inspector namespace.

BUG=none
R=dgozman@chromium.org
==========

to

==========
[test/inspector] remove any usage of v8::Extension

.. replace all of them with prepared global object template.

+ bonus: wrap inspector related methods with inspector namespace.

BUG=none
R=dgozman@chromium.org
==========

[dgozman, 2017-04-21 23:10:44]

lgtm

https://codereview.chromium.org/2832723004/diff/40001/test/inspector/inspecto...
File test/inspector/inspector-test.cc (right):

https://codereview.chromium.org/2832723004/diff/40001/test/inspector/inspecto...
test/inspector/inspector-test.cc:516: void UtilsExtension::CreateContextGroup(
Inline this back into place.

[kozy, 2017-04-21 23:16:54]

https://codereview.chromium.org/2832723004/diff/40001/test/inspector/inspecto...
File test/inspector/inspector-test.cc (right):

https://codereview.chromium.org/2832723004/diff/40001/test/inspector/inspecto...
test/inspector/inspector-test.cc:516: void UtilsExtension::CreateContextGroup(
On 2017/04/21 23:10:44, dgozman wrote:
> Inline this back into place.

It uses SetTimeoutExtension and InspectorExtension - it was original reason to
move extensions before UtilsExtension declaration.

[kozy, 2017-04-21 23:18:03]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-04-21 23:18:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 23:41:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492816683146660,
"parent_rev": "dddfcfd0a965199bdc41954d88f6e57e6cae17e1", "commit_rev":
"ec36c513a3b44c8afc3e2fb471c47395546a3faa"}

[commit-bot: I haz the power, 2017-04-21 23:41:13]

Description was changed from

==========
[test/inspector] remove any usage of v8::Extension

.. replace all of them with prepared global object template.

+ bonus: wrap inspector related methods with inspector namespace.

BUG=none
R=dgozman@chromium.org
==========

to

==========
[test/inspector] remove any usage of v8::Extension

.. replace all of them with prepared global object template.

+ bonus: wrap inspector related methods with inspector namespace.

BUG=none
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2832723004
Cr-Commit-Position: refs/heads/master@{#44785}
Committed:
https://chromium.googlesource.com/v8/v8/+/ec36c513a3b44c8afc3e2fb471c47395546...
==========

[commit-bot: I haz the power, 2017-04-21 23:41:14]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/ec36c513a3b44c8afc3e2fb471c47395546...