Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: test/inspector/inspector-impl.h

Issue 2832723004: [test/inspector] remove any usage of v8::Extension (Closed)
Patch Set: ac Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/inspector/inspector-impl.h
diff --git a/test/inspector/inspector-impl.h b/test/inspector/inspector-impl.h
index 5cff979c0ebc2c2c8f3165f25f77142ea3e98a91..4b1ca75dd80cb646a6e0eee576a7bc1f4b0cd51d 100644
--- a/test/inspector/inspector-impl.h
+++ b/test/inspector/inspector-impl.h
@@ -26,9 +26,9 @@ class InspectorClientImpl : public v8_inspector::V8InspectorClient {
virtual ~InspectorClientImpl();
void scheduleReconnect(v8::base::Semaphore* ready_semaphore);
- void scheduleCreateContextGroup(v8::ExtensionConfiguration* extensions,
- v8::base::Semaphore* ready_semaphore,
- int* context_group_id);
+ void scheduleCreateContextGroup(
+ TaskRunner::SetupGlobalTasks setup_global_tasks,
+ v8::base::Semaphore* ready_semaphore, int* context_group_id);
static v8_inspector::V8Inspector* InspectorFromContext(
v8::Local<v8::Context> context);
@@ -65,7 +65,8 @@ class InspectorClientImpl : public v8_inspector::V8InspectorClient {
friend class DisconnectTask;
void disconnect();
friend class CreateContextGroupTask;
- int createContextGroup(v8::ExtensionConfiguration* extensions);
+ int createContextGroup(
+ const TaskRunner::SetupGlobalTasks& setup_global_tasks);
std::unique_ptr<v8_inspector::V8Inspector> inspector_;
std::unique_ptr<v8_inspector::V8Inspector::Channel> channel_;
@@ -86,13 +87,9 @@ class InspectorClientImpl : public v8_inspector::V8InspectorClient {
DISALLOW_COPY_AND_ASSIGN(InspectorClientImpl);
};
-class SendMessageToBackendExtension : public v8::Extension {
+class SendMessageToBackendExtension : public TaskRunner::SetupGlobalTask {
public:
- SendMessageToBackendExtension()
- : v8::Extension("v8_inspector/frontend",
- "native function sendMessageToBackend();") {}
- virtual v8::Local<v8::FunctionTemplate> GetNativeFunctionTemplate(
- v8::Isolate* isolate, v8::Local<v8::String> name);
+ void Run(v8::Isolate* isolate, v8::Local<v8::ObjectTemplate> global) override;
static void set_backend_task_runner(TaskRunner* task_runner) {
backend_task_runner_ = task_runner;

Powered by Google App Engine
This is Rietveld 408576698