Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2832473004: Notify PasswordAutofillAgent about dynamic forms after the document was parsed. (Closed)

Created:
3 years, 8 months ago by vasilii
Modified:
3 years, 8 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, gcasto+watchlist_chromium.org, rwlbuis, sof, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Notify PasswordAutofillAgent about dynamic forms after the document was parsed. Previosly the form were reported after the document and all the resources were loaded. BUG=713645 Review-Url: https://codereview.chromium.org/2832473004 Cr-Commit-Position: refs/heads/master@{#466289} Committed: https://chromium.googlesource.com/chromium/src/+/5e87893ed5a96e6ab36de9280c8e647f7f8eb65b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -8 lines) Patch
M chrome/browser/password_manager/password_manager_browsertest.cc View 2 chunks +30 lines, -3 lines 0 comments Download
M chrome/test/data/password/between_parsing_and_rendering.html View 2 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
vasilii
Hi all, please review the CL.
3 years, 8 months ago (2017-04-20 11:15:49 UTC) #4
vabr (Chromium)
Thanks for the fix, LGTM! Vaclav
3 years, 8 months ago (2017-04-20 11:25:18 UTC) #5
vasilii
jochen@ please review Document.cpp
3 years, 8 months ago (2017-04-20 13:13:02 UTC) #9
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-21 08:37:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2832473004/1
3 years, 8 months ago (2017-04-21 08:43:33 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 08:46:54 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5e87893ed5a96e6ab36de9280c8e...

Powered by Google App Engine
This is Rietveld 408576698