Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9324)

Unified Diff: chrome/test/data/password/between_parsing_and_rendering.html

Issue 2832473004: Notify PasswordAutofillAgent about dynamic forms after the document was parsed. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/password/between_parsing_and_rendering.html
diff --git a/chrome/test/data/password/between_parsing_and_rendering.html b/chrome/test/data/password/between_parsing_and_rendering.html
index f7bb3e3949e5b16e6d5d505afed6972868923c91..0941b119c4b490d22f18d8f357cb337e7fcc3489 100644
--- a/chrome/test/data/password/between_parsing_and_rendering.html
+++ b/chrome/test/data/password/between_parsing_and_rendering.html
@@ -9,9 +9,10 @@ Three main points to note:
the form is not registered during form parsing stage
(as in PasswordManager::OnPasswordFormsParsed).
2. The form gets created before the rendering stage, so it gets
- registered during PasswordManager::OnPasswordFormsRendered.
-3. The form gets created before the main frame loads. Therefore
- the form is not registered during OnDynamicFormsSeen.
+ registered during PasswordManager::OnPasswordFormsRendered unless
+ it is hidden.
+3. The form gets created after the document loads. Therefore
+ the form is registered during OnDynamicFormsSeen.
The goal is to make sure that there is enough time between the form
creation and the frame load, so that OnDynamicFormsSeen is not
@@ -26,7 +27,10 @@ some webkit-only rules for background properties.
<script src="form_utils.js"></script>
<script>
function onLoadHandler() {
- document.body.appendChild(createSimplePasswordForm());
+ var form = createSimplePasswordForm();
+ if (location.search == '?hidden')
+ form.style.display = 'none';
+ document.body.appendChild(form);
}
</script>
<style>
« no previous file with comments | « chrome/browser/password_manager/password_manager_browsertest.cc ('k') | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698