Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 2832373002: Revert of Changing default Windows compiler to VS 2017 (Closed)

Created:
3 years, 8 months ago by findit-for-me
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Changing default Windows compiler to VS 2017 (patchset #9 id:160001 of https://codereview.chromium.org/2762093003/ ) Reason for revert: Findit(https://goo.gl/kROfz5) identified CL at revision 466536 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzU2MzRiZWNjM2NmNTVkZDE2ZDhlNWY2ZTU2YTcxMDVjNGVmY2Y4YWYM Original issue's description: > Changing default Windows compiler to VS 2017 > > This CL is currently purely for testing purposes. > > BUG=683729 > > Review-Url: https://codereview.chromium.org/2762093003 > Cr-Commit-Position: refs/heads/master@{#466536} > Committed: https://chromium.googlesource.com/chromium/src/+/5634becc3cf55dd16d8e5f6e56a7105c4efcf8af TBR=thakis@chromium.org,scottmg@chromium.org,dpranke@chromium.org,sebmarchand@chromium.org,brucedawson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=683729 Review-Url: https://codereview.chromium.org/2832373002 Cr-Commit-Position: refs/heads/master@{#466538} Committed: https://chromium.googlesource.com/chromium/src/+/a9d5d30b3deb074bb9eea410b75cd1d2220ac9ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/vs_toolchain.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
findit-for-me
Created Revert of Changing default Windows compiler to VS 2017
3 years, 8 months ago (2017-04-22 05:18:36 UTC) #1
findit-for-me
Sheriffs: Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct. If ...
3 years, 8 months ago (2017-04-22 05:18:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2832373002/1
3 years, 8 months ago (2017-04-22 16:24:46 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-22 16:24:47 UTC) #7
Guido Urdaneta
lgtm
3 years, 8 months ago (2017-04-22 18:39:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2832373002/1
3 years, 8 months ago (2017-04-22 18:39:45 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-22 18:40:40 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a9d5d30b3deb074bb9eea410b75c...

Powered by Google App Engine
This is Rietveld 408576698