Changing default Windows compiler to VS 2017

Changing default Windows compiler to VS 2017

This CL is currently purely for testing purposes.

BUG=683729
Review-Url: https://codereview.chromium.org/2762093003
Cr-Commit-Position: refs/heads/master@{#466536}
Committed: https://chromium.googlesource.com/chromium/src/+/5634becc3cf55dd16d8e5f6e56a7105c4efcf8af

[brucedawson, 2017-03-21 18:02:03]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 18:02:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 19:14:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 19:14:14]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2017-03-21 19:48:28]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 19:48:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 20:10:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 20:10:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brucedawson, 2017-03-21 20:21:55]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 20:22:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 20:44:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 20:44:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brucedawson, 2017-03-24 21:03:12]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 21:03:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2017-03-24 21:49:24]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 21:49:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 23:33:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 23:33:01]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[brucedawson, 2017-03-28 01:02:05]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 01:03:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 03:41:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 03:41:31]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[brucedawson, 2017-03-28 23:35:21]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 23:36:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 01:25:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 01:25:59]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[brucedawson, 2017-03-29 17:40:58]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 17:41:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 17:58:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 17:58:18]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[brucedawson, 2017-04-05 18:38:48]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 18:39:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2017-04-05 20:56:08]

Description was changed from

==========
VS 2017 and temporary landmine

This is not guaranteed to be the final package (it wasn't created on a
VM) and the landmine should be avoided in the final deployment if
possible. However this is handy for testing.

BUG=683729
==========

to

==========
VS 2017 and temporary landmine

This CL is currently purely for testing purposes. The landmine is
needed until gn rolls because otherwise the builders will not
trigger a build.

Once gn rolls a switch to VS 2017 should be as simple as changing
one character in vs_toolchain.py.

BUG=683729
==========

[commit-bot: I haz the power, 2017-04-05 21:00:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 21:00:31]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[brucedawson, 2017-04-05 23:53:34]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 23:54:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 02:24:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 02:24:28]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[brucedawson, 2017-04-06 17:56:12]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 17:57:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 20:10:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 20:10:48]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[brucedawson, 2017-04-14 23:43:13]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 23:43:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-15 02:33:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-15 02:33:23]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[brucedawson, 2017-04-17 19:02:14]

Description was changed from

==========
VS 2017 and temporary landmine

This CL is currently purely for testing purposes. The landmine is
needed until gn rolls because otherwise the builders will not
trigger a build.

Once gn rolls a switch to VS 2017 should be as simple as changing
one character in vs_toolchain.py.

BUG=683729
==========

to

==========
Changing default Windows compiler to VS 2017

This CL is currently purely for testing purposes.

BUG=683729
==========

[brucedawson, 2017-04-17 23:58:19]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 23:58:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 02:40:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 02:40:03]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[brucedawson, 2017-04-19 22:45:22]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 22:46:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2017-04-19 22:52:51]

brucedawson@chromium.org changed reviewers:
+ dpranke@chromium.org, scottmg@chromium.org, sebmarchand@chromium.org,
thakis@chromium.org

[brucedawson, 2017-04-19 22:52:52]

Hey, I'm thinking of landing this VS 2017 CL Friday night and then reverting it
Sunday night, to try to flush out any remaining problems. Please approve if you
like that plan, or object if you don't.

I'm running another set of try jobs, but looking at the current test results:
- the nacl_sdk failures are unrelated (crbug.com/629626)
- the win_chromium_rel_ng failures are from a VS 2017 RTM compiler bug and were
resolved by disabling those tests for that specific version
- SyzyAsan will fail with VS 2017 but that doesn't block this test, and
sebmarchand@ is planning to pin that builder to VS 2015 anyway (for now)
- the win_optional_gpu_tests_rel failures are not understood, but may just be
test flakiness

If approved then I'll send out a warning email on Thursday to chromium-dev@

[Nico, 2017-04-19 23:02:21]

Lgtm, sounds like a fine plan.

[Dirk Pranke, 2017-04-19 23:07:45]

lgtm also.

[commit-bot: I haz the power, 2017-04-20 00:25:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 00:25:27]

Dry run: This issue passed the CQ dry run.

[Sébastien Marchand, 2017-04-20 18:33:16]

On 2017/04/19 23:07:45, Dirk Pranke wrote:
> lgtm also.

lgtm too, I've submitted 2 CLs to pin the SyzyAsan bots to VS2015:
-
https://chrome-internal.googlesource.com/chrome/tools/build/+/c1b0c780a218b38...

- https://chromium-review.googlesource.com/c/483070/ (hasn't landed yet).

I'll also need to restart the official.desktop master for the first CL to take
effect.

[Sébastien Marchand, 2017-04-20 20:19:53]

FYI both CLs have landed and the official.desktop master has been restarted, so
this CL won't break SyzyAsan.

[brucedawson, 2017-04-22 02:52:29]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2017-04-22 02:52:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-22 04:29:56]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1492829549663120,
"parent_rev": "6f56a950ce7a91e149fbce18c3bd672f719dedb3", "commit_rev":
"5634becc3cf55dd16d8e5f6e56a7105c4efcf8af"}

[commit-bot: I haz the power, 2017-04-22 04:30:30]

Description was changed from

==========
Changing default Windows compiler to VS 2017

This CL is currently purely for testing purposes.

BUG=683729
==========

to

==========
Changing default Windows compiler to VS 2017

This CL is currently purely for testing purposes.

BUG=683729

Review-Url: https://codereview.chromium.org/2762093003
Cr-Commit-Position: refs/heads/master@{#466536}
Committed:
https://chromium.googlesource.com/chromium/src/+/5634becc3cf55dd16d8e5f6e56a7...
==========

[commit-bot: I haz the power, 2017-04-22 04:30:31]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/5634becc3cf55dd16d8e5f6e56a7...

[findit-for-me, 2017-04-22 05:18:36]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/2832373002/ by
findit-for-me@appspot.gserviceaccount.com.

The reason for reverting is: 
Findit(https://goo.gl/kROfz5) identified CL at revision 466536 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb....

[brucedawson, 2017-04-22 06:37:37]

On 2017/04/22 05:18:36, findit-for-me wrote:
> A revert of this CL (patchset #9 id:160001) has been created in
> https://codereview.chromium.org/2832373002/ by
> mailto:findit-for-me@appspot.gserviceaccount.com.
> 
> The reason for reverting is: 
> Findit(https://goo.gl/kROfz5) identified CL at revision 466536 as the
> culprit for failures in the build cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb....

New warnings on two builders, triggered by changes to the VC++ 2017 STL - I'll
investigate later:

FAILED: obj/v8/test/unittests/unittests/iterator-unittest.obj 
ninja -t msvc -e environment.x64 -- C:\b\c\goma_client/gomacc.exe
"C:\b\depot_tools\win_toolchain\vs_files\4e8a360587a3c8ff3fa46aa9271e982bf3e948ec\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64/cl.exe"
/nologo /showIncludes /FC
@obj/v8/test/unittests/unittests/iterator-unittest.obj.rsp /c
../../v8/test/unittests/base/iterator-unittest.cc
/Foobj/v8/test/unittests/unittests/iterator-unittest.obj
/Fd"obj/v8/test/unittests/unittests_cc.pdb"
c:\b\depot_tools\win_toolchain\vs_files\4e8a360587a3c8ff3fa46aa9271e982bf3e948ec\vc\tools\msvc\14.10.25017\include\xutility(3213):
error C2220: warning treated as error - no 'object' file generated
c:\b\depot_tools\win_toolchain\vs_files\4e8a360587a3c8ff3fa46aa9271e982bf3e948ec\vc\tools\msvc\14.10.25017\include\xutility(3224):
note: see reference to function template instantiation '__int64
std::_Count_unchecked<std::_Deque_unchecked_iterator<_Mydeque>,_Ty>(_InIt,_InIt,const
_Ty &)' being compiled
        with
        [
            _Mydeque=std::_Deque_val<std::_Deque_simple_types<unsigned int>>,
            _Ty=int,
           
_InIt=std::_Deque_unchecked_iterator<std::_Deque_val<std::_Deque_simple_types<unsigned
int>>>
        ]
c:\b\c\b\win_x64_archive\src\v8\test\unittests\base\iterator-unittest.cc(55):
note: see reference to function template instantiation '__int64
std::count<std::_Deque_iterator<std::_Deque_val<std::_Deque_simple_types<unsigned
int>>>,int>(_InIt,_InIt,const _Ty &)' being compiled
        with
        [
           
_InIt=std::_Deque_iterator<std::_Deque_val<std::_Deque_simple_types<unsigned
int>>>,
            _Ty=int
        ]
c:\b\depot_tools\win_toolchain\vs_files\4e8a360587a3c8ff3fa46aa9271e982bf3e948ec\vc\tools\msvc\14.10.25017\include\xutility(3213):
warning C4389: '==': signed/unsigned mismatch

[brucedawson, 2017-05-01 17:17:46]

I landed the follow-up change to this at about 4 am Saturday morning:

https://codereview.chromium.org/2852433005/

I left it in for about 44 hours but unfortunately no canary builds started
during that time period, so the test was not as complete as I would like. I will
be unavailable this coming weekend. If somebody else wants to retry the
experiment - maybe starting around 6 pm Friday instead of early Saturday - then
we could get some canary data. Otherwise I'll try it again the week after that.

It's at least good to know that the change didn't cause any issues for any
builders.

[Nico, 2017-05-01 17:24:51]

I'll try relanding it over the this weekend.

On Mon, May 1, 2017 at 1:17 PM, <brucedawson@chromium.org> wrote:

> I landed the follow-up change to this at about 4 am Saturday morning:
>
> https://codereview.chromium.org/2852433005/
>
> I left it in for about 44 hours but unfortunately no canary builds started
> during that time period, so the test was not as complete as I would like.
> I will
> be unavailable this coming weekend. If somebody else wants to retry the
> experiment - maybe starting around 6 pm Friday instead of early Saturday -
> then
> we could get some canary data. Otherwise I'll try it again the week after
> that.
>
> It's at least good to know that the change didn't cause any issues for any
> builders.
>
>
> https://codereview.chromium.org/2762093003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.