Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2832263004:
Fixing some strings that go into webrtc-internals. (Closed)
|
Created:
3 years, 8 months ago by Taylor_Brandstetter Modified:
3 years, 8 months ago CC:
chromium-reviews, posciak+watch_chromium.org, jam, darin-cc_chromium.org, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionFixing some strings that go into webrtc-internals.
Mainly, some enums were being displayed in their raw form, due to the
Blink Rename. For example, "kSignalingStateStable" instead of "stable".
BUG=chromium:714375
Review-Url: https://codereview.chromium.org/2832263004
Cr-Commit-Position: refs/heads/master@{#467267}
Committed: https://chromium.googlesource.com/chromium/src/+/fb4604d257703df68c8865db1a5d27f3059c2920
Patch Set 1 #
Total comments: 2
Patch Set 2 : Use different enum names between C++ and JS. #Messages
Total messages: 17 (7 generated)
deadbeef@chromium.org changed reviewers: + tommi@chromium.org
PTAL
https://codereview.chromium.org/2832263004/diff/1/content/renderer/media/peer... File content/renderer/media/peer_connection_tracker.cc (right): https://codereview.chromium.org/2832263004/diff/1/content/renderer/media/peer... content/renderer/media/peer_connection_tracker.cc:188: #define GET_STRING_OF_STATE(state) \ what about fixing the macro instead? e.g. case WebRTCPeerConnectionHandlerClient::k#state: result = #state; break; Then call it like so: GET_STRING_OF_STATE(SignalingStateStable) I'm not aware of a javascript style guide that says that constants should be named kFoo, so I'd like to avoid introducing that style to js just to appease the macro.
https://codereview.chromium.org/2832263004/diff/1/content/renderer/media/peer... File content/renderer/media/peer_connection_tracker.cc (right): https://codereview.chromium.org/2832263004/diff/1/content/renderer/media/peer... content/renderer/media/peer_connection_tracker.cc:188: #define GET_STRING_OF_STATE(state) \ On 2017/04/24 11:07:48, tommi - chröme wrote: > what about fixing the macro instead? > > e.g. > > case WebRTCPeerConnectionHandlerClient::k#state: > result = #state; > break; > > Then call it like so: GET_STRING_OF_STATE(SignalingStateStable) > > I'm not aware of a javascript style guide that says that constants should be > named kFoo, so I'd like to avoid introducing that style to js just to appease > the macro. It seemed simpler to me to have 2 possible enum values ("kSignalingStateStable" and "stable") rather than 3. But I don't feel too strongly so I'll go with your suggestion.
tommi@webrtc.org changed reviewers: + tommi@webrtc.org
The CQ bit was checked by tommi@webrtc.org
lgtm Thanks, yes it's a bit convoluted but I think it might be a good thing if a maintainer of the code accidentally pastes a C++ constant in there, the build will break.
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Need an lgtm from tommi chröme
Oops, lgtm
The CQ bit was checked by tommi@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493191647813380,
"parent_rev": "4b844c79e013f783d7154c8d7692f78d5c380496", "commit_rev":
"fb4604d257703df68c8865db1a5d27f3059c2920"}
Message was sent while issue was closed.
Description was changed from ========== Fixing some strings that go into webrtc-internals. Mainly, some enums were being displayed in their raw form, due to the Blink Rename. For example, "kSignalingStateStable" instead of "stable". BUG=chromium:714375 ========== to ========== Fixing some strings that go into webrtc-internals. Mainly, some enums were being displayed in their raw form, due to the Blink Rename. For example, "kSignalingStateStable" instead of "stable". BUG=chromium:714375 Review-Url: https://codereview.chromium.org/2832263004 Cr-Commit-Position: refs/heads/master@{#467267} Committed: https://chromium.googlesource.com/chromium/src/+/fb4604d257703df68c8865db1a5d... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/fb4604d257703df68c8865db1a5d... |
