Fixing some strings that go into webrtc-internals.

content/renderer/media/peer_connection_tracker.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/peer_connection_tracker.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
@@ skipping 159 matching lines @@
   default:
     NOTREACHED();
   };
   return policy_str;
 }
 
 static std::string SerializeConfiguration(
     const webrtc::PeerConnectionInterface::RTCConfiguration& config) {
   std::ostringstream oss;
   // TODO(hbos): Add serialization of certificate.
-  oss << "{ iceServers: " << SerializeServers(config.servers) << ", "
-      << "iceTransportPolicy: " << SerializeIceTransportType(config.type)
-      << ", "
-      << "bundlePolicy: " << SerializeBundlePolicy(config.bundle_policy) << ", "
-      << "rtcpMuxPolicy: " << SerializeRtcpMuxPolicy(config.rtcp_mux_policy)
-      << "iceCandidatePoolSize: " << config.ice_candidate_pool_size << " }";
+  oss << "{ iceServers: " << SerializeServers(config.servers)
+      << ", iceTransportPolicy: " << SerializeIceTransportType(config.type)
+      << ", bundlePolicy: " << SerializeBundlePolicy(config.bundle_policy)
+      << ", rtcpMuxPolicy: " << SerializeRtcpMuxPolicy(config.rtcp_mux_policy)
+      << ", iceCandidatePoolSize: " << config.ice_candidate_pool_size << " }";
   return oss.str();
 }
 
 #define GET_STRING_OF_STATE(state)                \

[tommi (sloooow) - chröme, 2017/04/24 11:07:48]

what about fixing the macro instead?

e.g.

case WebRTCPeerConnectionHandlerClient::k#state:
  result = #state;
  break;

Then call it like so: GET_STRING_OF_STATE(SignalingStateStable)

I'm not aware of a javascript style guide that says that constants should be
named kFoo, so I'd like to avoid introducing that style to js just to appease
the macro.

[Taylor_Brandstetter, 2017/04/24 20:24:40]

It seemed simpler to me to have 2 possible enum values ("kSignalingStateStable"
and "stable") rather than 3. But I don't feel too strongly so I'll go with your
suggestion.

   case WebRTCPeerConnectionHandlerClient::state:  \
     result = #state;                              \
     break;
 
+// Note: All of these strings need to be kept in sync with
+// peer_connection_update_table.js, in order to be displayed as friendly
+// strings on chrome://webrtc-internals.
+
 static const char* GetSignalingStateString(
     WebRTCPeerConnectionHandlerClient::SignalingState state) {
   const char* result = "";
   switch (state) {
     GET_STRING_OF_STATE(kSignalingStateStable)
     GET_STRING_OF_STATE(kSignalingStateHaveLocalOffer)
     GET_STRING_OF_STATE(kSignalingStateHaveRemoteOffer)
     GET_STRING_OF_STATE(kSignalingStateHaveLocalPrAnswer)
     GET_STRING_OF_STATE(kSignalingStateHaveRemotePrAnswer)
     GET_STRING_OF_STATE(kSignalingStateClosed)
@@ skipping 536 matching lines @@
   DCHECK(main_thread_.CalledOnValidThread());
   SendTarget()->Send(new PeerConnectionTrackerHost_UpdatePeerConnection(
       local_id, std::string(callback_type), value));
 }
 
 void PeerConnectionTracker::OverrideSendTargetForTesting(RenderThread* target) {
   send_target_for_test_ = target;
 }
 
 }  // namespace content