Increase timeout for complete state for globo story

Increase timeout for complete state for globo story

Android One someties takes longer to load.

BUG=713036
Review-Url: https://codereview.chromium.org/2831973002
Cr-Commit-Position: refs/heads/master@{#466209}
Committed: https://chromium.googlesource.com/chromium/src/+/8ce14996ccd3915bec8c5507cd0e34c5d651f663

[ssid, 2017-04-20 20:37:28]

ssid@chromium.org changed reviewers:
+ nednguyen@google.com

[ssid, 2017-04-20 20:37:29]

PTAL thanks

[ssid, 2017-04-20 20:37:44]

The CQ bit was checked by ssid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 20:38:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2017-04-20 20:43:43]

lgtm with nits

https://codereview.chromium.org/2831973002/diff/1/tools/perf/page_sets/system...
File tools/perf/page_sets/system_health/browsing_stories.py (right):

https://codereview.chromium.org/2831973002/diff/1/tools/perf/page_sets/system...
tools/perf/page_sets/system_health/browsing_stories.py:72:
COMPLETE_STATE_WAIT_TIMEOUT = None
why not just default this to 90s
(https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry...)
to avoid the awkward if else below.

[commit-bot: I haz the power, 2017-04-20 21:55:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 21:55:29]

Dry run: This issue passed the CQ dry run.

[ssid, 2017-04-20 22:29:24]

https://codereview.chromium.org/2831973002/diff/1/tools/perf/page_sets/system...
File tools/perf/page_sets/system_health/browsing_stories.py (right):

https://codereview.chromium.org/2831973002/diff/1/tools/perf/page_sets/system...
tools/perf/page_sets/system_health/browsing_stories.py:72:
COMPLETE_STATE_WAIT_TIMEOUT = None
On 2017/04/20 20:43:43, nednguyen wrote:
> why not just default this to 90s
>
(https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry...)
> to avoid the awkward if else below.

I cannot import catapult/telemetry/telemetry/internal/browser/web_contents.py in
this file. So, cannot use the constant.

If someone decides to change the constant in that file in future for some
reason, and forget to change this then all syste_health stories would start
failing. That is the reason I kept it as None.

wdyt?

[nednguyen, 2017-04-20 22:33:52]

On 2017/04/20 22:29:24, ssid wrote:
>
https://codereview.chromium.org/2831973002/diff/1/tools/perf/page_sets/system...
> File tools/perf/page_sets/system_health/browsing_stories.py (right):
> 
>
https://codereview.chromium.org/2831973002/diff/1/tools/perf/page_sets/system...
> tools/perf/page_sets/system_health/browsing_stories.py:72:
> COMPLETE_STATE_WAIT_TIMEOUT = None
> On 2017/04/20 20:43:43, nednguyen wrote:
> > why not just default this to 90s
> >
>
(https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry...)
> > to avoid the awkward if else below.
> 
> I cannot import catapult/telemetry/telemetry/internal/browser/web_contents.py
in
> this file. So, cannot use the constant.
> 
> If someone decides to change the constant in that file in future for some
> reason, and forget to change this then all syste_health stories would start
> failing. That is the reason I kept it as None.
> 
> wdyt?

ah I see. that's a good reason, though can you add some comment in code to
explain it to future reader? lgtm

[ssid, 2017-04-20 23:48:00]

The CQ bit was checked by ssid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 23:48:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 01:00:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 01:00:54]

Dry run: This issue passed the CQ dry run.

[ssid, 2017-04-21 01:15:16]

The CQ bit was checked by ssid@chromium.org

[ssid, 2017-04-21 01:15:16]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2831973002/#ps20001
(title: "add comment.")

[commit-bot: I haz the power, 2017-04-21 01:15:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 01:20:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492737316032960,
"parent_rev": "2c58d0f9979aa1fa1400a34894231606e561236e", "commit_rev":
"8ce14996ccd3915bec8c5507cd0e34c5d651f663"}

[commit-bot: I haz the power, 2017-04-21 01:20:43]

Description was changed from

==========
Increase timeout for complete state for globo story

Android One someties takes longer to load.

BUG=713036
==========

to

==========
Increase timeout for complete state for globo story

Android One someties takes longer to load.

BUG=713036

Review-Url: https://codereview.chromium.org/2831973002
Cr-Commit-Position: refs/heads/master@{#466209}
Committed:
https://chromium.googlesource.com/chromium/src/+/8ce14996ccd3915bec8c5507cd0e...
==========

[commit-bot: I haz the power, 2017-04-21 01:20:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8ce14996ccd3915bec8c5507cd0e...