Increase timeout for complete state for globo story

tools/perf/page_sets/system_health/browsing_stories.py

 # encoding: utf-8
 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from page_sets.system_health import platforms
 from page_sets.system_health import story_tags
 from page_sets.system_health import system_health_story
 
 from page_sets.login_helpers import pinterest_login
@@ skipping 50 matching lines @@
   4. Open and scroll the second article.
   5. Go back to the main page and scroll it.
   6. etc.
   """
 
   ITEM_READ_TIME_IN_SECONDS = 3
   ITEM_SCROLL_REPEAT = 2
   ITEMS_TO_VISIT = 4
   MAIN_PAGE_SCROLL_REPEAT = 0
   ABSTRACT_STORY = True
+  # Some devices take long to load news webpages crbug.com/713036.
+  COMPLETE_STATE_WAIT_TIMEOUT = None

[nednguyen, 2017/04/20 20:43:43]

why not just default this to 90s
(https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry...)
to avoid the awkward if else below.

[ssid, 2017/04/20 22:29:24]

I cannot import catapult/telemetry/telemetry/internal/browser/web_contents.py in
this file. So, cannot use the constant.

If someone decides to change the constant in that file in future for some
reason, and forget to change this then all syste_health stories would start
failing. That is the reason I kept it as None.

wdyt?

 
   def _DidLoadDocument(self, action_runner):
     for i in xrange(self.ITEMS_TO_VISIT):
       self._NavigateToItem(action_runner, i)
       self._ReadNextArticle(action_runner)
       self._NavigateBack(action_runner)
       self._ScrollMainPage(action_runner)
 
   def _ReadNextArticle(self, action_runner):
-    action_runner.tab.WaitForDocumentReadyStateToBeComplete()
+    if self.COMPLETE_STATE_WAIT_TIMEOUT is not None:
+      action_runner.tab.WaitForDocumentReadyStateToBeComplete(
+          timeout=self.COMPLETE_STATE_WAIT_TIMEOUT)
+    else:
+      action_runner.tab.WaitForDocumentReadyStateToBeComplete()
     action_runner.Wait(self.ITEM_READ_TIME_IN_SECONDS/2.0)
     action_runner.RepeatableBrowserDrivenScroll(
         repeat_count=self.ITEM_SCROLL_REPEAT)
     action_runner.Wait(self.ITEM_READ_TIME_IN_SECONDS/2.0)
 
   def _ScrollMainPage(self, action_runner):
     action_runner.tab.WaitForDocumentReadyStateToBeComplete()
     action_runner.RepeatableBrowserDrivenScroll(
         repeat_count=self.MAIN_PAGE_SCROLL_REPEAT)
 
@@ skipping 472 matching lines @@
 class BrowseTOIMobileStory(_ArticleBrowsingStory):
   NAME = 'browse:news:toi'
   URL = 'http://m.timesofindia.com'
   SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
   TAGS = [story_tags.EMERGING_MARKET]
 
   ITEMS_TO_VISIT = 4
   ITEM_SELECTOR = '.dummy-img'
 
 
-@decorators.Disabled('android')  # crbug.com/713036.
 class BrowseGloboMobileStory(_ArticleBrowsingStory):
   NAME = 'browse:news:globo'
   URL = 'http://www.globo.com'
   SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
   TAGS = [story_tags.EMERGING_MARKET]
 
   ITEMS_TO_VISIT = 4
   ITEM_SELECTOR = '.hui-premium__title'
+  COMPLETE_STATE_WAIT_TIMEOUT = 150
 
 
 class BrowseCricBuzzMobileStory(_ArticleBrowsingStory):
   NAME = 'browse:news:cricbuzz'
   URL = 'http://m.cricbuzz.com'
   SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
   TAGS = [story_tags.EMERGING_MARKET]
 
   ITEMS_TO_VISIT = 3
   ITEM_SELECTOR = '.list-content'
@@ skipping 181 matching lines @@
     # Reduce the speed (the current wpr is recorded with speed set to 50)  when
     # recording the wpr. If we scroll too fast, the data will not be recorded
     # well. After recording reset it back to the original value to have a more
     # realistic scroll.
     action_runner.RepeatableBrowserDrivenScroll(
         x_scroll_distance_ratio = 0.0, y_scroll_distance_ratio = 1,
         repeat_count=3, speed=400, timeout=120)
     action_runner.RepeatableBrowserDrivenScroll(
         x_scroll_distance_ratio = 1, y_scroll_distance_ratio = 0,
         repeat_count=3, speed=500, timeout=120)