Issue 283193002: gn: Reuse IsAsciiAlpha() function from base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 283193002: gn: Reuse IsAsciiAlpha() function from base. (Closed)

Created:
6 years, 7 months ago by tfarina

Modified:
6 years, 7 months ago

Reviewers:
scottmg

CC:
chromium-reviews, brettw

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

gn: Reuse IsAsciiAlpha() function from base. This also fix a typo in ninja_toolchain_writer.h: s/assicoated/associated R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270826

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -5 lines)			Patch
M	tools/gn/filesystem_utils.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	tools/gn/ninja_toolchain_writer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gn/tokenizer.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

tfarina

6 years, 7 months ago (2014-05-15 21:52:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r270826 (presubmit successful).