tools/gn/filesystem_utils.cc - Issue 283193002: gn: Reuse IsAsciiAlpha() function from base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/filesystem_utils.cc

Issue 283193002: gn: Reuse IsAsciiAlpha() function from base. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/filesystem_utils.cc

diff --git a/tools/gn/filesystem_utils.cc b/tools/gn/filesystem_utils.cc

index 9140f80660e94f69abdf7d667bcc4cb1d372f9e2..4cfefa9dc7ee658448233ae08a5af04473e69c2b 100644

--- a/tools/gn/filesystem_utils.cc

+++ b/tools/gn/filesystem_utils.cc

@@ -99,9 +99,8 @@ bool DoesBeginWindowsDriveLetter(const base::StringPiece& path) {

if (path[1] != ':')

return false;

- // Check drive letter

- if (!((path[0] >= 'A' && path[0] <= 'Z') ||

- path[0] >= 'a' && path[0] <= 'z'))

+ // Check drive letter.

+ if (!IsAsciiAlpha(path[0]))

return false;

if (!IsSlash(path[2]))

« no previous file with comments | « no previous file | tools/gn/ninja_toolchain_writer.h » ('j') | no next file with comments »