Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: tools/gn/tokenizer.h

Issue 283193002: gn: Reuse IsAsciiAlpha() function from base. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_toolchain_writer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/tokenizer.h
diff --git a/tools/gn/tokenizer.h b/tools/gn/tokenizer.h
index a980478729aecfa4f2622fdc546f8bdabc495533..13d79097ce39a1f38809f2f53c122680896d5b77 100644
--- a/tools/gn/tokenizer.h
+++ b/tools/gn/tokenizer.h
@@ -33,7 +33,7 @@ class Tokenizer {
static bool IsNewline(const base::StringPiece& buffer, size_t offset);
static bool IsIdentifierFirstChar(char c) {
- return (c >= 'A' && c <= 'Z') || (c >= 'a' && c <= 'z') || c == '_';
+ return IsAsciiAlpha(c) || c == '_';
}
static bool IsIdentifierContinuingChar(char c) {
« no previous file with comments | « tools/gn/ninja_toolchain_writer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698